feat(Network): Description field feature #978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #978 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 151 151
Lines 5500 5509 +9
Branches 1105 1066 -39
=========================================
+ Hits 5500 5509 +9 ☔ View full report in Codecov by Sentry. |
jamaljsr
reviewed
Aug 16, 2024
There was a problem hiding this comment.
Thanks for implementing this. Overall everything looks great. I just have a few small suggestions for improvement.
- since there are now multiple fields, it would be good to have placeholders on them so it's clear what each field if for.
- I found an existing bug while testing this. If I don't enter a name, the error message is not displayed properly because the lang key doesn't exist in the
en-US.jsonfile. Would you mind fixing this here in this PR?
- I feel like the description is taking up extra space and doesn't really need to be displayed at all times. I like the tooltip on the main Networks screen. Can you use that info icon on this screen as well?
|
Hi @jamaljsr Thanks for your review. I'll look into the bug you mentioned and revert to the tooltip. |
20b5949 to
877517b
Compare
|
Hi @jamaljsr Updated the PR with the bug fix and your suggestion. Kindly review. Thanks |
jamaljsr
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #836
Replaces #848
Description
This feature adds a new optional field for the description of each network along with the network name.
Steps to Test
Screenshots
Home view
NetworkView