fix(network-card): added taro nodes stat to network card #668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amovfx
commented
Feb 8, 2023
jamaljsr
reviewed
Feb 8, 2023
src/components/home/NetworkCard.tsx
Outdated
| @@ -43,6 +43,13 @@ const NetworkCard: React.FC<{ network: Network }> = ({ network }) => { | |||
| suffix={<LinkOutlined />} | |||
| /> | |||
| </Col> | |||
| <Col span={12}> | |||
There was a problem hiding this comment.
I'm not a big fan of the empty space in the second column. You could get all 3 on one row by setting span={8} on all columns and removing the "Nodes" from the titles.
src/components/home/NetworkCard.tsx
Outdated
| <Statistic | ||
| title={l('taroNodes')} | ||
| value={network.nodes.taro.length} | ||
| suffix={<ApiOutlined />} |
There was a problem hiding this comment.
antd doesn't provide a lot of icons to choose from but I think the DollarOutlined one makes more sense for Taro since the primary goal of the project is to bring stablecoins to Bitcoin.
jamaljsr
approved these changes
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated Network card to display the amount of taro nodes.
Steps to Test