Remove unreachable condition and bring PHPStan to Level5 #151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This brings bunny to PHPStan Level 5
|
Uhm, intend is good. Except that file is generated: Line 27 in 32c747c |
|
Shoot, I didn't look into the header! I thought only the Sorry for the waste of time! |
|
No worries, loving the work and the energy you put into these PR's 👍 . if you still want to fix it, try and fix it from the generation script. Going to be a lot harder tho 😅 |
This was referenced May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed the
elseifbranch because it made the same check and was never reached. I'm not familiar enough with what's happening to know if the second branch was meant to check for something else, though 😅