Skip to content

Make sure when --es.num-replicas=0, ES indexes have numReplicas set to 0 instead of 1 #754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 26, 2018
Merged

Make sure when --es.num-replicas=0, ES indexes have numReplicas set to 0 instead of 1 #754

merged 4 commits into from
Mar 26, 2018

Conversation

bharat-p
Copy link
Member

@bharat-p bharat-p commented Mar 23, 2018 •
edited
Loading

Resolves #369

See original PR#371 (which I messed up while updating my outdated branch) for past discussion around this.

ES number of replicas was getting set to 1 even when specifying --es.num-replicas=0 when starting collector and query, which caused a single node ES cluster to be always in "yellow" state with unassigned shards.

Before fix:

output of localhost:9200/_cluster/health?pretty

curl "localhost:9200/_cluster/health?pretty"                                                         [Mar 22, 7:06 PM]
{
  "cluster_name" : "jaeger-cluster",
  "status" : "yellow",
  "timed_out" : false,
  "number_of_nodes" : 1,
  "number_of_data_nodes" : 1,
  "active_primary_shards" : 10,
  "active_shards" : 10,
  "relocating_shards" : 0,
  "initializing_shards" : 0,
  "unassigned_shards" : 10,
  "delayed_unassigned_shards" : 0,
  "number_of_pending_tasks" : 0,
  "number_of_in_flight_fetch" : 0,
  "task_max_waiting_in_queue_millis" : 0,
  "active_shards_percent_as_number" : 50.0
}

output of http://localhost:9200/jaeger-span-2018-03-23/_settings?pretty

curl "http://localhost:9200/jaeger-span-2018-03-23/_settings?pretty"                                 [Mar 22, 7:07 PM]
{
  "jaeger-span-2018-03-23" : {
    "settings" : {
      "index" : {
        "mapping" : {
          "nested_fields" : {
            "limit" : "50"
          }
        },
        "number_of_shards" : "5",
        "provided_name" : "jaeger-span-2018-03-23",
        "mapper" : {
          "dynamic" : "false"
        },
        "creation_date" : "1521770836101",
        "requests" : {
          "cache" : {
            "enable" : "true"
          }
        },
        "number_of_replicas" : "1",
        "uuid" : "GxfUsJRzQP25QyFw1M0gGg",
        "version" : {
          "created" : "5050399"
        }
      }
    }
  }
}

Verified after fix:
output of http://localhost:9200/_cluster/health?pretty

{
  "cluster_name" : "jaeger-cluster",
  "status" : "green",
  "timed_out" : false,
  "number_of_nodes" : 1,
  "number_of_data_nodes" : 1,
  "active_primary_shards" : 10,
  "active_shards" : 10,
  "relocating_shards" : 0,
  "initializing_shards" : 0,
  "unassigned_shards" : 0,
  "delayed_unassigned_shards" : 0,
  "number_of_pending_tasks" : 0,
  "number_of_in_flight_fetch" : 0,
  "task_max_waiting_in_queue_millis" : 0,
  "active_shards_percent_as_number" : 100.0
}

After fix output of http://localhost:9200/jaeger-span-2018-03-23/_settings?pretty

curl "http://localhost:9200/jaeger-span-2018-03-23/_settings?pretty"                                [Mar 22, 7:02 PM]
{
  "jaeger-span-2018-03-23" : {
    "settings" : {
      "index" : {
        "mapping" : {
          "nested_fields" : {
            "limit" : "50"
          }
        },
        "number_of_shards" : "5",
        "provided_name" : "jaeger-span-2018-03-23",
        "mapper" : {
          "dynamic" : "false"
        },
        "creation_date" : "1521770529358",
        "requests" : {
          "cache" : {
            "enable" : "true"
          }
        },
        "number_of_replicas" : "0",
        "uuid" : "rMVWSG4uRgmEQDlXyKu-DA",
        "version" : {
          "created" : "5050399"
        }
      }
    }
  }
}

@bharat-p
Make sure when --es.num-replicas=0, ES indexes have numReplicas set t…
ce2d650 
…o 0 instead of 1 (jaegertracing#369)

Signed-off-by: Bharat Patel <bharrat@gmail.com>
@bharat-p
Don't change default option from 1
623fa92 
Signed-off-by: Bharat Patel <bharrat@gmail.com>
@bharat-p bharat-p force-pushed the bharat-es-replica-fix branch from 405ba64 to 623fa92 Compare March 23, 2018 02:11
@bharat-p
Run make fmt, to make sure code is formatted correctly
3eb8e59 
Signed-off-by: Bharat Patel <bharrat@gmail.com>
@coveralls
Copy link

coveralls commented Mar 23, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 21f6b64 on bharat-p:bharat-es-replica-fix into 83d06da on jaegertracing:master.

@yurishkuro yurishkuro mentioned this pull request Mar 23, 2018
Closed
@pavolloffay
Copy link
Member

@bharat-p thanks!

@pavolloffay pavolloffay merged commit 437c010 into jaegertracing:master Mar 26, 2018
@pavolloffay
Copy link
Member

At some point, we should consider externalizing all ES configuration.

@pavolloffay pavolloffay mentioned this pull request Mar 29, 2018
Open
@Jorgevillada Jorgevillada mentioned this pull request May 14, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavolloffay pavolloffay pavolloffay approved these changes

@black-adder black-adder Awaiting requested review from black-adder

@vprithvi vprithvi Awaiting requested review from vprithvi

@yurishkuro yurishkuro Awaiting requested review from yurishkuro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ES replicas defaults to 1 even when specifying --es.num-replicas=0 when starting collector and query
3 participants
@bharat-p @coveralls @pavolloffay