Skip to content

Apply namespace when creating Prometheus metrics factory (fix for #732) #733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 9, 2018
Merged

Apply namespace when creating Prometheus metrics factory (fix for #732) #733

merged 1 commit into from
Mar 9, 2018

Conversation

yurishkuro
Copy link
Member

Resolves #732

Signed-off-by: Yuri Shkuro ys@uber.com

@ghost ghost assigned yurishkuro Mar 8, 2018
@ghost ghost added the review label Mar 8, 2018
@yurishkuro yurishkuro mentioned this pull request Mar 8, 2018
Closed
@coveralls
Copy link

coveralls commented Mar 9, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling abb5901 on fix-732 into 5d4fed6 on master.

@yurishkuro yurishkuro merged commit 6fce4f9 into master Mar 9, 2018
@ghost ghost removed the review label Mar 9, 2018
@yurishkuro yurishkuro deleted the fix-732 branch May 6, 2018 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavolloffay pavolloffay Awaiting requested review from pavolloffay

@vprithvi vprithvi Awaiting requested review from vprithvi

1 more reviewer

@black-adder black-adder black-adder approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@yurishkuro yurishkuro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yurishkuro @coveralls @black-adder