Serve Hotrod UI and Grafana from Separate Basepaths in Jaeger Demo #7328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chahat sagar <109112505+chahatsagarmain@users.noreply.github.com>
examples/oci/jaeger-values.yaml
Outdated
| @@ -6,6 +6,7 @@ hotrod: | |||
| - all | |||
| extraArgs: | |||
| - --otel-exporter=otlp | |||
| - --basepath=hotrod | |||
There was a problem hiding this comment.
The --basepath argument needs a leading slash to align with the ingress path configuration. Please update from --basepath=hotrod to --basepath=/hotrod to ensure proper routing between the ingress and the application.
Suggested change
| - --basepath=hotrod | |
| - --basepath=/hotrod |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
yurishkuro
reviewed
Jul 17, 2025
examples/oci/ingress.yaml
Outdated
| @@ -15,8 +15,8 @@ spec: | |||
| name: jaeger-query | |||
| port: | |||
| number: 16686 | |||
| - path: /grafana | |||
| pathType: Prefix | |||
| - path: /grafana(/|$)(.*) | |||
There was a problem hiding this comment.
(/|$) doesn't make sense if followed by .*, since $ marks the end of the string
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7328 +/- ##
=======================================
Coverage 96.26% 96.26%
=======================================
Files 377 377
Lines 22900 22900
=======================================
Hits 22044 22044
Misses 647 647
Partials 209 209
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yurishkuro
approved these changes
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test