Skip to content

Conversation

gokulvootla
Copy link
Contributor

Which problem is this PR solving?

  • Fixes #6295: Jaeger example missing OTLP HTTP receiver on port 4318 in examples/grafana-integration/docker-compose.yaml.

Description of the changes

  • Added port 4318 under ports: for the jaeger service in the grafana-integration/docker-compose.yaml file to expose the OTLP HTTP receiver.
  • This ensures compatibility with OTLP HTTP exporters like the OpenTelemetry Collector.

How was this change tested?

  • Ran docker compose up -d in examples/grafana-integration/
  • Verified that port 4318 is exposed using docker ps and docker inspect
gokul@gokul-VMware-Virtual-Platform:~/PR/jaeger/examples/grafana-integration$ docker inspect grafana-integration-jaeger-1 | grep 4318
                "4318/tcp": [
                        "HostPort": "4318"
                "4318/tcp": {},
                "4318/tcp": [
                        "HostPort": "4318"
                        "HostPort": "4318"
  • Also validated that the port is open and responds (expected 404 for GET request):
curl -v http://localhost:4318
* Host localhost:4318 was resolved.
* IPv6: ::1
* IPv4: 127.0.0.1
*   Trying [::1]:4318...
* Connected to localhost (::1) port 4318
> GET / HTTP/1.1
> Host: localhost:4318
> User-Agent: curl/8.5.0
> Accept: */*
>
< HTTP/1.1 404 Not Found
< Content-Type: text/plain; charset=utf-8
< Vary: Origin
< X-Content-Type-Options: nosniff
< Date: Thu, 17 Jul 2025 17:41:43 GMT
< Content-Length: 19
<
404 page not found
* Connection #0 to host localhost left intact

@gokulvootla gokulvootla requested a review from a team as a code owner July 17, 2025 17:45
@gokulvootla gokulvootla requested a review from mahadzaryab1 July 17, 2025 17:45
@dosubot dosubot bot added the docker Pull requests that update Docker code label Jul 17, 2025
… testing

Signed-off-by: gokulvootla <gokuled98@gmail.com>
@gokulvootla gokulvootla force-pushed the fix/jaeger-4318-port-exposure branch from ff909fe to 8e212e5 Compare July 17, 2025 17:54
@yurishkuro yurishkuro changed the title fix: expose Jaeger 4318 OTLP HTTP port to support Grafana integration… Expose Jaeger 4318 OTLP HTTP port in Grafana integration example Jul 17, 2025
@yurishkuro yurishkuro enabled auto-merge July 17, 2025 18:06
Copy link

codecov bot commented Jul 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.28%. Comparing base (a9c1473) to head (8e212e5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7325   +/-   ##
=======================================
  Coverage   96.27%   96.28%           
=======================================
  Files         377      377           
  Lines       22900    22900           
=======================================
+ Hits        22047    22049    +2     
+ Misses        645      643    -2     
  Partials      208      208           
Flag Coverage Δ
badger_v1 9.17% <ø> (ø)
badger_v2 1.75% <ø> (ø)
cassandra-4.x-v1-manual 11.91% <ø> (ø)
cassandra-4.x-v2-auto 1.74% <ø> (ø)
cassandra-4.x-v2-manual 1.74% <ø> (ø)
cassandra-5.x-v1-manual 11.91% <ø> (ø)
cassandra-5.x-v2-auto 1.74% <ø> (ø)
cassandra-5.x-v2-manual 1.74% <ø> (ø)
elasticsearch-6.x-v1 16.77% <ø> (ø)
elasticsearch-7.x-v1 16.82% <ø> (ø)
elasticsearch-8.x-v1 16.98% <ø> (ø)
elasticsearch-8.x-v2 1.75% <ø> (ø)
grpc_v1 10.42% <ø> (ø)
grpc_v2 1.75% <ø> (ø)
kafka-3.x-v1 9.33% <ø> (ø)
kafka-3.x-v2 1.75% <ø> (ø)
memory_v2 1.75% <ø> (ø)
opensearch-1.x-v1 16.86% <ø> (ø)
opensearch-2.x-v1 16.86% <ø> (ø)
opensearch-2.x-v2 1.75% <ø> (ø)
query 1.75% <ø> (ø)
tailsampling-processor 0.48% <ø> (ø)
unittests 95.20% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yurishkuro yurishkuro added this pull request to the merge queue Jul 17, 2025
Merged via the queue into jaegertracing:main with commit 598e0a2 Jul 17, 2025
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:bugfix-or-minor-feature docker Pull requests that update Docker code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: missing jaeger service 4318 port in examples/grafana-integration docker-compose file
2 participants