[spm] Add optimisation by time range #7322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pipiland2612
commented
Jul 16, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7322 +/- ##
==========================================
- Coverage 96.46% 96.44% -0.02%
==========================================
Files 378 378
Lines 22910 22927 +17
==========================================
+ Hits 22101 22113 +12
- Misses 612 616 +4
- Partials 197 198 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pipiland2612
commented
Jul 16, 2025
be3f64d to
3411203
Compare
yurishkuro
reviewed
Jul 18, 2025
internal/storage/v1/elasticsearch/spanstore/index_utils_test.go
Outdated
Show resolved
Hide resolved
yurishkuro
reviewed
Jul 18, 2025
yurishkuro
reviewed
Jul 18, 2025
yurishkuro
reviewed
Jul 18, 2025
Signed-off-by: pipiland2612 <nguyen.t.dang.minh@gmail.com>
Signed-off-by: pipiland2612 <nguyen.t.dang.minh@gmail.com>
47b3e7e to
9b5dd2c
Compare
Signed-off-by: pipiland2612 <nguyen.t.dang.minh@gmail.com>
pipiland2612
commented
Jul 20, 2025
| @@ -225,7 +231,7 @@ func timeRangeIndices(indexName, indexDateLayout string, startTime time.Time, en | |||
| var indices []string | |||
| firstIndex := indexWithDate(indexName, indexDateLayout, startTime) | |||
| currentIndex := indexWithDate(indexName, indexDateLayout, endTime) | |||
| for currentIndex != firstIndex { | |||
| for currentIndex != firstIndex && endTime.After(startTime) { | |||
There was a problem hiding this comment.
I add this check to prevent infinite loop
|
Hi @yurishkuro, the pr is ready for your review! Thanks |
yurishkuro
approved these changes
Jul 20, 2025
Merged
via the queue into
jaegertracing:main
with commit Jul 20, 2025
3cce66e
61 of 62 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
How was this change tested?
bash scripts/e2e/spm.sh -b jaeger -m elasticsearchrun successfullyChecklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test