Any reason not to convert these to strings here so that we don't have to do it all over the code??

@yurishkuro Because codebase has a mixed usage pattern where semantic convention keys are needed in two different contexts

1. Internal operations (attribute lookups, map keys, string comparisons) that require string constants
   examples:

• to_dbmodel.go: Uses conventions.ServiceNameKey as string for comparisons
  

  jaeger/internal/storage/v2/elasticsearch/tracestore/to_dbmodel.go

  Line 84 in a9c1473

  if key == conventions.AttributeServiceName {

• memory.go: Uses conventions.ServiceNameKey as string for attribute lookups
  

  jaeger/internal/storage/v2/memory/memory.go

  Line 223 in a9c1473

  val, ok := resource.Attributes().Get(conventions.AttributeServiceName)

2. OpenTelemetry SDK calls that require attribute.Key types with methods like .String()
   examples:

• main.go: Needs conventions.ServiceNameKey.String(svc) for resource attributes
  

  jaeger/cmd/tracegen/main.go

  Line 89 in a9c1473

  resource.WithAttributes(otelsemconv.ServiceNameKey.String(svc)),

• query_logger.go : `conventions.DBSystemKey.String("elasticsearch")
  

  jaeger/internal/storage/metricstore/elasticsearch/query_logger.go

  Line 37 in a9c1473

  otelsemconv.DBSystemKey.String("elasticsearch"),

@yurishkuro Should i Modify semconv.go to provide both string constants and attribute.Key types??

something like

const (
    ServiceNameKeyStr = "service.name"
)

var (
    ServiceNameKey = semconv.ServiceNameKey
)
  

how many places where the actual attribute is required? If it's just a couple, I would convert all Key constants to strings but for the places where the actual attribute is being created define functions, e.g.

func ServiceNameAttribute(value strign) {
  return otel.ServiceNameKey.String(svc) 
}

@yurishkuro got it ! , atrribute keys are used in total of six files, namely :