Skip to content

[spm e2e] Add e2e test for new spm (using ElasticSearch as metrics_backend) #7307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 13, 2025
Merged

[spm e2e] Add e2e test for new spm (using ElasticSearch as metrics_backend) #7307

merged 3 commits into from
Jul 13, 2025

Conversation

pipiland2612
Copy link
Contributor

Which problem is this PR solving?

Description of the changes

  • Add e2e test for new spm by changing the current config-spm-elasticsearch to use ES as metrics backend, delete duplicate config-spm-without-prometheus.
  • Add check for NaN value inside spm e2e

How was this change tested?

  • CI and manual testing

Checklist

@pipiland2612
Add e2e test for new spm
470cbc9 
Signed-off-by: pipiland2612 <nguyen.t.dang.minh@gmail.com>
@pipiland2612 pipiland2612 requested a review from a team as a code owner July 11, 2025 06:50
@pipiland2612 pipiland2612 requested a review from jkowall July 11, 2025 06:50
@pipiland2612 pipiland2612 mentioned this pull request Jul 11, 2025
Closed
4 tasks
@codecov Codecov
Copy link

codecov bot commented Jul 11, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.15%. Comparing base (9058c04) to head (918ffb1).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7307      +/-   ##
==========================================
- Coverage   96.17%   96.15%   -0.03%     
==========================================
  Files         377      377              
  Lines       22886    22886              
==========================================
- Hits        22011    22006       -5     
- Misses        659      663       +4     
- Partials      216      217       +1
Flag Coverage Δ
badger_v1 9.17% <ø> (ø)
badger_v2 1.75% <ø> (ø)
cassandra-4.x-v1-manual 11.91% <ø> (ø)
cassandra-4.x-v2-auto 1.74% <ø> (ø)
cassandra-4.x-v2-manual 1.74% <ø> (ø)
cassandra-5.x-v1-manual 11.91% <ø> (ø)
cassandra-5.x-v2-auto 1.74% <ø> (ø)
cassandra-5.x-v2-manual 1.74% <ø> (ø)
elasticsearch-6.x-v1 16.66% <ø> (ø)
elasticsearch-7.x-v1 16.71% <ø> (ø)
elasticsearch-8.x-v1 16.87% <ø> (ø)
elasticsearch-8.x-v2 1.75% <ø> (ø)
grpc_v1 10.42% <ø> (ø)
grpc_v2 1.75% <ø> (ø)
kafka-3.x-v1 9.34% <ø> (ø)
kafka-3.x-v2 1.75% <ø> (ø)
memory_v2 1.75% <ø> (ø)
opensearch-1.x-v1 16.75% <ø> (ø)
opensearch-2.x-v1 16.75% <ø> (ø)
opensearch-2.x-v2 1.75% <ø> (ø)
query 1.75% <ø> (ø)
tailsampling-processor 0.48% <ø> (ø)
unittests 95.07% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pipiland2612
Copy link
Contributor Author

Hi @yurishkuro, the pr is now ready for your review

yurishkuro
yurishkuro reviewed Jul 12, 2025
View reviewed changes
yurishkuro
yurishkuro reviewed Jul 12, 2025
View reviewed changes
yurishkuro
yurishkuro reviewed Jul 12, 2025
View reviewed changes
yurishkuro
yurishkuro reviewed Jul 12, 2025
View reviewed changes
@pipiland2612
Fix
9d25a94 
Signed-off-by: pipiland2612 <nguyen.t.dang.minh@gmail.com>
@pipiland2612 pipiland2612 requested a review from yurishkuro July 13, 2025 12:39
@yurishkuro yurishkuro added the changelog:ci Change related to continuous integration / testing label Jul 13, 2025
@yurishkuro yurishkuro enabled auto-merge July 13, 2025 13:46
@yurishkuro yurishkuro added this pull request to the merge queue Jul 13, 2025
Merged via the queue into jaegertracing:main with commit 4e198de Jul 13, 2025
59 of 60 checks passed
@pipiland2612 pipiland2612 deleted the e2e_new_spm branch July 13, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurishkuro yurishkuro yurishkuro approved these changes

@jkowall jkowall Awaiting requested review from jkowall jkowall is a code owner automatically assigned from jaegertracing/jaeger-maintainers

Assignees
No one assigned
Labels
changelog:ci Change related to continuous integration / testing storage/elasticsearch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pipiland2612 @yurishkuro