Skip to content

[spm] Add opensearch option #7304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 14, 2025
Merged

[spm] Add opensearch option #7304

merged 3 commits into from
Jul 14, 2025

Conversation

pipiland2612
Copy link
Contributor

@pipiland2612 pipiland2612 commented Jul 10, 2025 •
edited
Loading

Which problem is this PR solving?

Description of the changes

  • Add option for OpenSearch inside config.go and extension.go
  • Add e2e test for OpenSearch spm

How was this change tested?

  • CI
  • Manual testing

Checklist

@pipiland2612 pipiland2612 requested a review from a team as a code owner July 10, 2025 07:51
@pipiland2612 pipiland2612 requested a review from pavolloffay July 10, 2025 07:51
@pipiland2612 pipiland2612 changed the title Add opensearch support [spm] Add opensearch option Jul 10, 2025
@pipiland2612
Copy link
Contributor Author

After W4 has been done I will add docker-compose file and e2e test for opensearch too

@codecov Codecov
Copy link

codecov bot commented Jul 10, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.17%. Comparing base (4e198de) to head (5be3b99).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7304      +/-   ##
==========================================
- Coverage   96.18%   96.17%   -0.02%     
==========================================
  Files         377      377              
  Lines       22886    22898      +12     
==========================================
+ Hits        22014    22023       +9     
- Misses        657      659       +2     
- Partials      215      216       +1
Flag Coverage Δ
badger_v1 9.17% <ø> (ø)
badger_v2 1.75% <0.00%> (-0.01%) ⬇️
cassandra-4.x-v1-manual 11.91% <ø> (ø)
cassandra-4.x-v2-auto 1.74% <0.00%> (-0.01%) ⬇️
cassandra-4.x-v2-manual 1.74% <0.00%> (-0.01%) ⬇️
cassandra-5.x-v1-manual 11.91% <ø> (ø)
cassandra-5.x-v2-auto 1.74% <0.00%> (-0.01%) ⬇️
cassandra-5.x-v2-manual 1.74% <0.00%> (-0.01%) ⬇️
elasticsearch-6.x-v1 16.66% <ø> (ø)
elasticsearch-7.x-v1 16.71% <ø> (ø)
elasticsearch-8.x-v1 16.87% <ø> (ø)
elasticsearch-8.x-v2 1.75% <0.00%> (-0.01%) ⬇️
grpc_v1 10.42% <ø> (ø)
grpc_v2 1.75% <0.00%> (-0.01%) ⬇️
kafka-3.x-v1 9.34% <ø> (ø)
kafka-3.x-v2 1.75% <0.00%> (-0.01%) ⬇️
memory_v2 1.75% <0.00%> (-0.01%) ⬇️
opensearch-1.x-v1 16.75% <ø> (ø)
opensearch-2.x-v1 16.75% <ø> (ø)
opensearch-2.x-v2 1.75% <0.00%> (-0.01%) ⬇️
query 1.75% <0.00%> (-0.01%) ⬇️
tailsampling-processor 0.48% <0.00%> (-0.01%) ⬇️
unittests 95.09% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

yurishkuro
yurishkuro reviewed Jul 12, 2025
View reviewed changes
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you expecting backend changes to support working with OS? I.e. does it need different query shapes / aggregation queries?

If not, let's add the e2e integration test to enable OS, otherwise this PR makes it available via config without actually verifying that it works.

@yurishkuro yurishkuro added the changelog:exprimental Change to an experimental part of the code label Jul 12, 2025
@pipiland2612
Copy link
Contributor Author

pipiland2612 commented Jul 13, 2025 •
edited
Loading

Hi @yurishkuro, it makes sense to also add e2e test for os in this pr too. Originally I plan to add in the follow up pr, but I think it should be in this pr too!

@pipiland2612
Add opensearch support
421e9aa 
Signed-off-by: pipiland2612 <nguyen.t.dang.minh@gmail.com>
@pipiland2612
Add e2e test for opensearch
e71ff65 
Signed-off-by: pipiland2612 <nguyen.t.dang.minh@gmail.com>
@pipiland2612 pipiland2612 requested a review from yurishkuro July 13, 2025 17:01
graphite-app[bot]
graphite-app bot reviewed Jul 13, 2025
View reviewed changes
@pipiland2612
Refactor spm.sh
5be3b99 
Signed-off-by: pipiland2612 <nguyen.t.dang.minh@gmail.com>
@pipiland2612
Copy link
Contributor Author

Hi @yurishkuro, I have added e2e test for opensearch for this pr also. It's now good to go! Thanks for your support

@yurishkuro yurishkuro added this pull request to the merge queue Jul 14, 2025
Merged via the queue into jaegertracing:main with commit c843f13 Jul 14, 2025
61 checks passed
@pipiland2612 pipiland2612 deleted the Opensearch_support branch July 14, 2025 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

@yurishkuro yurishkuro yurishkuro approved these changes

@pavolloffay pavolloffay Awaiting requested review from pavolloffay pavolloffay is a code owner automatically assigned from jaegertracing/jaeger-maintainers

Assignees
No one assigned
Labels
area/storage changelog:exprimental Change to an experimental part of the code enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pipiland2612 @yurishkuro