Add /deep-dependencies endpoint
#7399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7399 +/- ##
==========================================
- Coverage 96.46% 96.46% -0.01%
==========================================
Files 375 377 +2
Lines 22951 23071 +120
==========================================
+ Hits 22140 22255 +115
- Misses 613 617 +4
- Partials 198 199 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This commit introduce new endpint with fake deep dependencies data. Resolves jaegertracing#6606. Signed-off-by: Sujal Shah <sujalshah28092004@gmail.com>
0237520 to
44388c7
Compare
sujalshah-bit
added a commit
to sujalshah-bit/jaeger-ui
that referenced
this pull request
Jul 30, 2025
This commit updates the Deep Dependency Graph UI logic to use the correct backend API endpoint for fetching data. Resolves [#6606](jaegertracing/jaeger#6606). Part of [#7399](jaegertracing/jaeger#7399). Signed-off-by: Sujal Shah <sujalshah28092004@gmail.com>
4 tasks
yurishkuro
reviewed
Aug 2, 2025
Signed-off-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
/deep-dependencies endpoint/deep-dependencies endpoint
| @@ -876,6 +877,21 @@ func TestGetQualityMetrics(t *testing.T) { | |||
| require.Contains(t, resp.TraceQualityDocumentationLink, "github.com/jaegertracing") | |||
| } | |||
|
|
|||
| func TestGetDeepDependenciesData(t *testing.T) { | |||
| handler := &APIHandler{} | |||
There was a problem hiding this comment.
The test creates an empty APIHandler without initialization, which may cause failures when writeJSON() is called in the deepDependencies handler. Consider using initializeTestServer() (as used in other tests) or initializing the handler with required dependencies like a logger. This would better match the production environment and ensure all handler dependencies are properly satisfied.
Suggested change
| handler := &APIHandler{} | |
| handler := initializeTestServer(nil) |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
yurishkuro
approved these changes
Aug 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduce new endpint with fake
deep dependencies data.
Part of #6606.
Screenshots and Screencaptures
output.mov
NOTE: The above graph shown in the visuals will only be shown after UI changes(See PR ). This PR only focuses on the backend level change.
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test