-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Add metrics_storage to config-elasticsearch/opensearch #7390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7390 +/- ##
==========================================
- Coverage 96.44% 96.43% -0.02%
==========================================
Files 375 375
Lines 22878 22878
==========================================
- Hits 22065 22062 -3
- Misses 615 617 +2
- Partials 198 199 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Tests failed |
Signed-off-by: pipiland2612 <nguyen.t.dang.minh@gmail.com>
The original plan was to repoint the e2e test docker file to config-elasticsearch/opensearch. But the dilemma is that this config-es/os is used for es/os e2e test which requires
to run successfully. On the other hand, spm e2e test requires:
to run successfully. I ask Gemmini to explain why we need
For this change, you can locally test the step I specify above and it runs good |
Did you test that with these settings the commands I showed in the issue result in the Monitor tab being operational? |
Yes I did test that. |
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger
:make lint test
jaeger-ui
:npm run lint
andnpm run test