Skip to content

Conversation

pipiland2612
Copy link
Contributor

@pipiland2612 pipiland2612 commented Jul 28, 2025

Which problem is this PR solving?

Description of the changes

  • Add metrics_storage to current cmd/jaeger/config-elasticsearch.yml (also cmd/jaeger/config-opensearch.yml)

How was this change tested?

  • Run commands successfully:
$ cd docker-compose/elasticsearch/v9
$ docker compose up
go run ./cmd/jaeger --config ./cmd/jaeger/config-elasticsearch.yaml

Checklist

@pipiland2612 pipiland2612 requested a review from a team as a code owner July 28, 2025 11:36
@pipiland2612 pipiland2612 requested a review from jkowall July 28, 2025 11:36
@dosubot dosubot bot added area/storage docker Pull requests that update Docker code labels Jul 28, 2025
Copy link

codecov bot commented Jul 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.43%. Comparing base (c241f67) to head (9ee4659).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7390      +/-   ##
==========================================
- Coverage   96.44%   96.43%   -0.02%     
==========================================
  Files         375      375              
  Lines       22878    22878              
==========================================
- Hits        22065    22062       -3     
- Misses        615      617       +2     
- Partials      198      199       +1     
Flag Coverage Δ
badger_v1 9.11% <ø> (ø)
badger_v2 1.72% <ø> (ø)
cassandra-4.x-v1-manual 11.83% <ø> (ø)
cassandra-4.x-v2-auto 1.71% <ø> (ø)
cassandra-4.x-v2-manual 1.71% <ø> (ø)
cassandra-5.x-v1-manual 11.83% <ø> (ø)
cassandra-5.x-v2-auto 1.71% <ø> (ø)
cassandra-5.x-v2-manual 1.71% <ø> (ø)
elasticsearch-6.x-v1 16.80% <ø> (ø)
elasticsearch-7.x-v1 16.85% <ø> (ø)
elasticsearch-8.x-v1 16.99% <ø> (ø)
elasticsearch-8.x-v2 1.72% <ø> (ø)
elasticsearch-9.x-v2 1.72% <ø> (ø)
grpc_v1 10.35% <ø> (ø)
grpc_v2 1.72% <ø> (ø)
kafka-3.x-v1 9.28% <ø> (ø)
kafka-3.x-v2 1.72% <ø> (ø)
memory_v2 1.72% <ø> (ø)
opensearch-1.x-v1 16.89% <ø> (ø)
opensearch-2.x-v1 16.89% <ø> (ø)
opensearch-2.x-v2 1.72% <ø> (ø)
opensearch-3.x-v2 1.72% <ø> (ø)
query 1.72% <ø> (ø)
tailsampling-processor 0.47% <ø> (ø)
unittests 95.41% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yurishkuro yurishkuro added the changelog:exprimental Change to an experimental part of the code label Jul 28, 2025
@yurishkuro
Copy link
Member

Tests failed

Signed-off-by: pipiland2612 <nguyen.t.dang.minh@gmail.com>
@pipiland2612
Copy link
Contributor Author

pipiland2612 commented Jul 28, 2025

The original plan was to repoint the e2e test docker file to config-elasticsearch/opensearch. But the dilemma is that this config-es/os is used for es/os e2e test which requires

          server_urls:
            - http://localhost:9200

to run successfully. On the other hand, spm e2e test requires:

          server_urls:
            - http://elasticsearch:9200

to run successfully. I ask Gemmini to explain why we need - http://elasticsearch:9200 but not - http://localhost:9200. It says like this:

The issue you encountered is related to how Docker containers communicate with each other within a Docker network. Here's why changing localhost to elasticsearch fixed the problem:

Key Points:
Container Networking in Docker:

Each container in Docker has its own network namespace (its own "localhost")

localhost inside a container refers to that container itself, not the host machine or other containers

Containers can communicate with each other using their service names as hostnames

Your Specific Case:

When Jaeger was configured with http://localhost:9200, it was looking for Elasticsearch on its own local network (inside the Jaeger container), which didn't exist

When you changed it to http://elasticsearch:9200, it correctly looked for the Elasticsearch service in the Docker network

Docker Compose Networking:

Your services are connected via the backend network

Docker automatically sets up DNS resolution so containers can find each other by service name

The elasticsearch hostname resolves to the Elasticsearch container's IP within the Docker network

For this change, you can locally test the step I specify above and it runs good

@yurishkuro yurishkuro merged commit 1e69052 into jaegertracing:main Jul 28, 2025
63 checks passed
@yurishkuro
Copy link
Member

Did you test that with these settings the commands I showed in the issue result in the Monitor tab being operational?

@pipiland2612
Copy link
Contributor Author

Yes I did test that.

@pipiland2612 pipiland2612 deleted the SPM_W8 branch July 28, 2025 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/storage changelog:exprimental Change to an experimental part of the code docker Pull requests that update Docker code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[W8]: Make Monitor tab automatically enabled when using ES/OS
2 participants