Fix enforce-switch-style linting errors #7387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let me know if any changes are needed. I’ll be happy to adjust the PR as necessary. |
yurishkuro
reviewed
Jul 27, 2025
| @@ -444,6 +444,8 @@ func mergeJoinIds(left, right [][]byte) [][]byte { | |||
| case -1: | |||
| // left < right, increase left one | |||
| l++ | |||
| default: | |||
There was a problem hiding this comment.
Doesn't make sense in this context. I'd rather move case 0 to default (and change the others to greater/less 0)
yurishkuro
approved these changes
Jul 27, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7387 +/- ##
==========================================
- Coverage 96.46% 96.46% -0.01%
==========================================
Files 375 375
Lines 22878 22910 +32
==========================================
+ Hits 22070 22099 +29
- Misses 611 613 +2
- Partials 197 198 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
auto-merge was automatically disabled
July 27, 2025 20:53
Head branch was pushed to by a user without write access
yurishkuro
approved these changes
Jul 28, 2025
…dling Signed-off-by: Andrei-hub11 <andreirodrigues794@gmail.com>
Signed-off-by: Andrei-hub11 <andreirodrigues794@gmail.com>
auto-merge was automatically disabled
July 28, 2025 22:20
Head branch was pushed to by a user without write access
|
Hi @yurishkuro Sorry for the multiple CI failures. I've now run golangci-lint locally and confirmed all issues are resolved. |
internal/storage/v2/elasticsearch/tracestore/to_dbmodel_test.go
Outdated
Show resolved
Hide resolved
yurishkuro
approved these changes
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
defaultcases to switch statements across the codebase to comply with new linting rules.Changes
defaultcases to 15+ switch statementsnoctxerror by replacingnet.Listenwith(*net.ListenConfig).ListenAll changes preserve original functionality while satisfying linting requirements.
Closes: #7383
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test