Skip to content

Remove pool.go/pool.stop method (deadcode) #7373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 26, 2025
Merged

Remove pool.go/pool.stop method (deadcode) #7373

merged 1 commit into from
Jul 26, 2025

Conversation

Parship999
Copy link
Contributor

Which problem is this PR solving?

Description of the changes

  • Working on: examples/hotrod/pkg/pool/pool.go (Pool.Stop Method)
  • Files identified by deadcode tool: examples/hotrod/pkg/pool/pool.go: - Pool.Stop method unreachable
  • When introduced: PR Add demo tracing app #40
  • When fixed: PR Fix HotRod job pool termination (#1453) #1454
  • current state: Pool.Stop() method is never called anywhere in the codebase. Only Pool.New() and Pool.Execute() are used in production
  • Files to modify: examples/hotrod/pkg/pool/pool.go - remove Stop() method

Checklist

@Parship999
remove deadcode pool-pool.stop
c5d4fc7 
Signed-off-by: Parship Chowdhury <i.am.parship@gmail.com>
@Parship999 Parship999 requested a review from a team as a code owner July 25, 2025 06:16
@Parship999 Parship999 requested a review from joe-elliott July 25, 2025 06:16
@codecov Codecov
Copy link

codecov bot commented Jul 25, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.43%. Comparing base (4d6ac93) to head (c5d4fc7).
⚠️ Report is 17 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7373      +/-   ##
==========================================
- Coverage   96.44%   96.43%   -0.02%     
==========================================
  Files         375      375              
  Lines       22871    22878       +7     
==========================================
+ Hits        22058    22062       +4     
- Misses        615      617       +2     
- Partials      198      199       +1
Flag Coverage Δ
badger_v1 9.11% <ø> (-0.10%) ⬇️
badger_v2 1.72% <ø> (-0.02%) ⬇️
cassandra-4.x-v1-manual 11.83% <ø> (-0.13%) ⬇️
cassandra-4.x-v2-auto 1.71% <ø> (-0.02%) ⬇️
cassandra-4.x-v2-manual 1.71% <ø> (-0.02%) ⬇️
cassandra-5.x-v1-manual 11.83% <ø> (-0.13%) ⬇️
cassandra-5.x-v2-auto 1.71% <ø> (-0.02%) ⬇️
cassandra-5.x-v2-manual 1.71% <ø> (-0.02%) ⬇️
elasticsearch-6.x-v1 16.80% <ø> (+<0.01%) ⬆️
elasticsearch-7.x-v1 16.85% <ø> (-0.01%) ⬇️
elasticsearch-8.x-v1 16.99% <ø> (-0.01%) ⬇️
elasticsearch-8.x-v2 1.72% <ø> (-0.02%) ⬇️
elasticsearch-9.x-v2 1.72% <ø> (?)
grpc_v1 10.35% <ø> (-0.11%) ⬇️
grpc_v2 1.72% <ø> (-0.02%) ⬇️
kafka-3.x-v1 9.28% <ø> (-0.10%) ⬇️
kafka-3.x-v2 1.72% <ø> (-0.02%) ⬇️
memory_v2 1.72% <ø> (-0.02%) ⬇️
opensearch-1.x-v1 16.89% <ø> (-0.01%) ⬇️
opensearch-2.x-v1 16.89% <ø> (-0.01%) ⬇️
opensearch-2.x-v2 1.72% <ø> (-0.02%) ⬇️
opensearch-3.x-v2 1.72% <ø> (-0.02%) ⬇️
query 1.72% <ø> (-0.02%) ⬇️
tailsampling-processor 0.47% <ø> (-0.01%) ⬇️
unittests 95.41% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yurishkuro yurishkuro added the changelog:refactoring Internal code refactoring without functional changes label Jul 26, 2025
@yurishkuro
Copy link
Member

@Parship999 you have done a number of "good first issue" tickets already, I suggest you leave them for other contributors and maybe try something harder than just dead code removal 😄

@yurishkuro yurishkuro merged commit 2bbb1e4 into jaegertracing:main Jul 26, 2025
63 of 64 checks passed
@Parship999
Copy link
Contributor Author

@Parship999 you have done a number of "good first issue" tickets already, I suggest you leave them for other contributors and maybe try something harder than just dead code removal 😄

Yes, sure! even today i was thinking the same, time to take on something more challenging🙂 Thanks for the suggestion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurishkuro yurishkuro yurishkuro approved these changes

@joe-elliott joe-elliott Awaiting requested review from joe-elliott joe-elliott is a code owner automatically assigned from jaegertracing/jaeger-maintainers

Assignees
No one assigned
Labels
changelog:refactoring Internal code refactoring without functional changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Parship999 @yurishkuro