Skip to content

Remove deadcode jptrace/utf8 #7369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 25, 2025
Merged

Remove deadcode jptrace/utf8 #7369

merged 2 commits into from
Jul 25, 2025

Conversation

Parship999
Copy link
Contributor

@Parship999 Parship999 commented Jul 23, 2025 •
edited
Loading

Which problem is this PR solving?

Description of the changes

  • Files identified by deadcode tool: internal/jptrace/utf8.go - SanitizeUTF8 function unreachable
  • When introduced: PR [Fix] Fix prometheus label value is not valid utf 8 cause api timeout #7128
  • When unused: the pr that introduced it never actually used the function
  • The fix was implemented by switching from WithLabelValues() to GetMetricWithLabelValues() in the prometheus factory, the SanitizeUTF8 function was added but never used.
  • Files to remove:
    • internal/jptrace/utf8.go
    • internal/jptrace/utf8_test.go

Checklist

@Parship999
remove deadcode jptrace/utf8
6ec7245 
Signed-off-by: Parship Chowdhury <i.am.parship@gmail.com>
@Parship999 Parship999 requested a review from a team as a code owner July 23, 2025 19:24
@Parship999 Parship999 requested a review from pavolloffay July 23, 2025 19:24
@yurishkuro
Copy link
Member

please add history analysis to the PR. This whole package is relatively new, it's surprising that there is dead code there.

@Parship999
Copy link
Contributor Author

please add history analysis to the PR. This whole package is relatively new, it's surprising that there is dead code there.

done

@yurishkuro yurishkuro added the changelog:refactoring Internal code refactoring without functional changes label Jul 23, 2025
@codecov Codecov
Copy link

codecov bot commented Jul 23, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.47%. Comparing base (b407a8d) to head (46033ae).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7369      +/-   ##
==========================================
+ Coverage   96.44%   96.47%   +0.03%     
==========================================
  Files         376      375       -1     
  Lines       22957    22953       -4     
==========================================
+ Hits        22141    22145       +4     
+ Misses        617      611       -6     
+ Partials      199      197       -2
Flag Coverage Δ
badger_v1 9.14% <ø> (+<0.01%) ⬆️
badger_v2 1.72% <ø> (+<0.01%) ⬆️
cassandra-4.x-v1-manual 11.87% <ø> (+<0.01%) ⬆️
cassandra-4.x-v2-auto 1.72% <ø> (+<0.01%) ⬆️
cassandra-4.x-v2-manual 1.72% <ø> (+<0.01%) ⬆️
cassandra-5.x-v1-manual 11.87% <ø> (+<0.01%) ⬆️
cassandra-5.x-v2-auto 1.72% <ø> (+<0.01%) ⬆️
cassandra-5.x-v2-manual 1.72% <ø> (+<0.01%) ⬆️
elasticsearch-6.x-v1 16.70% <ø> (+<0.01%) ⬆️
elasticsearch-7.x-v1 16.74% <ø> (+<0.01%) ⬆️
elasticsearch-8.x-v1 16.89% <ø> (+<0.01%) ⬆️
elasticsearch-8.x-v2 1.72% <ø> (+<0.01%) ⬆️
grpc_v1 10.38% <ø> (+<0.01%) ⬆️
grpc_v2 1.72% <ø> (+<0.01%) ⬆️
kafka-3.x-v1 9.30% <ø> (+<0.01%) ⬆️
kafka-3.x-v2 1.72% <ø> (+<0.01%) ⬆️
memory_v2 1.72% <ø> (+<0.01%) ⬆️
opensearch-1.x-v1 16.79% <ø> (+<0.01%) ⬆️
opensearch-2.x-v1 16.79% <ø> (+<0.01%) ⬆️
opensearch-2.x-v2 1.72% <ø> (+<0.01%) ⬆️
opensearch-3.x-v2 1.72% <ø> (+<0.01%) ⬆️
query 1.72% <ø> (+<0.01%) ⬆️
tailsampling-processor 0.47% <ø> (+<0.01%) ⬆️
unittests 95.46% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yurishkuro yurishkuro enabled auto-merge July 23, 2025 21:52
@yurishkuro yurishkuro added this pull request to the merge queue Jul 23, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 23, 2025
@yurishkuro yurishkuro added this pull request to the merge queue Jul 25, 2025
Merged via the queue into jaegertracing:main with commit 13e6b4a Jul 25, 2025
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurishkuro yurishkuro yurishkuro approved these changes

@pavolloffay pavolloffay Awaiting requested review from pavolloffay pavolloffay is a code owner automatically assigned from jaegertracing/jaeger-maintainers

Assignees
No one assigned
Labels
changelog:refactoring Internal code refactoring without functional changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Parship999 @yurishkuro