Skip to content

Removing dead code from thrift/jaeger #7365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 25, 2025
Merged

Removing dead code from thrift/jaeger #7365

merged 1 commit into from
Jul 25, 2025

Conversation

wololowarrior
Copy link
Contributor

@wololowarrior wololowarrior commented Jul 23, 2025 •
edited
Loading

Which problem is this PR solving?

Description of the changes

Files Removed as part of this pr:

  • internal/converter/thrift/jaeger/from_domain.go
  • internal/converter/thrift/jaeger/from_domain_test.go

How was this change tested?

  • Unit test

Checklist

@wololowarrior
Removing dead from_domain code
2667708 
Signed-off-by: Harshil Gupta <harshilgupta1808@gmail.com>
@wololowarrior wololowarrior requested a review from a team as a code owner July 23, 2025 07:32
@wololowarrior wololowarrior changed the title Removing dead from_domain code Removing dead code from thrift/jaeger Jul 23, 2025
@yurishkuro yurishkuro added the changelog:refactoring Internal code refactoring without functional changes label Jul 25, 2025
@yurishkuro yurishkuro enabled auto-merge July 25, 2025 01:51
@codecov Codecov
Copy link

codecov bot commented Jul 25, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.45%. Comparing base (4d6ac93) to head (2667708).
Report is 8 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff            @@
##             main    #7365    +/-   ##
========================================
  Coverage   96.44%   96.45%            
========================================
  Files         375      374     -1     
  Lines       22871    22764   -107     
========================================
- Hits        22058    21956   -102     
+ Misses        615      611     -4     
+ Partials      198      197     -1
Flag Coverage Δ
badger_v1 9.21% <ø> (ø)
badger_v2 1.74% <ø> (ø)
cassandra-4.x-v1-manual 11.96% <ø> (ø)
cassandra-4.x-v2-auto 1.73% <ø> (ø)
cassandra-4.x-v2-manual 1.73% <ø> (ø)
cassandra-5.x-v1-manual 11.96% <ø> (ø)
cassandra-5.x-v2-auto 1.73% <ø> (ø)
cassandra-5.x-v2-manual 1.73% <ø> (ø)
elasticsearch-6.x-v1 16.80% <ø> (ø)
elasticsearch-7.x-v1 16.85% <ø> (ø)
elasticsearch-8.x-v1 16.99% <ø> (ø)
elasticsearch-8.x-v2 1.74% <ø> (ø)
grpc_v1 10.46% <ø> (ø)
grpc_v2 1.74% <ø> (ø)
kafka-3.x-v1 9.37% <ø> (ø)
kafka-3.x-v2 1.74% <ø> (ø)
memory_v2 1.74% <ø> (ø)
opensearch-1.x-v1 16.89% <ø> (ø)
opensearch-2.x-v1 16.89% <ø> (ø)
opensearch-2.x-v2 1.74% <ø> (ø)
opensearch-3.x-v2 1.74% <ø> (ø)
query 1.74% <ø> (ø)
tailsampling-processor 0.48% <ø> (ø)
unittests 95.42% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yurishkuro yurishkuro added this pull request to the merge queue Jul 25, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 25, 2025
@yurishkuro yurishkuro added this pull request to the merge queue Jul 25, 2025
Merged via the queue into jaegertracing:main with commit 2d31ced Jul 25, 2025
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurishkuro yurishkuro yurishkuro approved these changes

@pavolloffay pavolloffay Awaiting requested review from pavolloffay pavolloffay is a code owner automatically assigned from jaegertracing/jaeger-maintainers

Assignees
No one assigned
Labels
changelog:refactoring Internal code refactoring without functional changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove dead code
2 participants
@wololowarrior @yurishkuro