Skip to content

Conversation

Parship999
Copy link
Contributor

@Parship999 Parship999 commented Jul 22, 2025

Which problem is this PR solving?

Description of the changes

  • Files removed:
    • cmd/collector/app/sanitizer/utf8_sanitizer.go
    • cmd/collector/app/sanitizer/utf8_sanitizer_test.go

Checklist

Signed-off-by: Parship Chowdhury <i.am.parship@gmail.com>
@Parship999 Parship999 requested a review from a team as a code owner July 22, 2025 21:01
@Parship999 Parship999 requested a review from joe-elliott July 22, 2025 21:01
Copy link

codecov bot commented Jul 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.45%. Comparing base (b059cc6) to head (b55759f).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7363      +/-   ##
==========================================
- Coverage   96.47%   96.45%   -0.03%     
==========================================
  Files         378      375       -3     
  Lines       22999    22867     -132     
==========================================
- Hits        22189    22057     -132     
  Misses        613      613              
  Partials      197      197              
Flag Coverage Δ
badger_v1 9.21% <ø> (+0.10%) ⬆️
badger_v2 1.74% <ø> (ø)
cassandra-4.x-v1-manual 11.96% <ø> (+0.14%) ⬆️
cassandra-4.x-v2-auto 1.73% <ø> (ø)
cassandra-4.x-v2-manual 1.73% <ø> (ø)
cassandra-5.x-v1-manual 11.96% <ø> (+0.14%) ⬆️
cassandra-5.x-v2-auto 1.73% <ø> (ø)
cassandra-5.x-v2-manual 1.73% <ø> (ø)
elasticsearch-6.x-v1 16.81% <ø> (+0.19%) ⬆️
elasticsearch-7.x-v1 16.85% <ø> (+0.19%) ⬆️
elasticsearch-8.x-v1 17.00% <ø> (+0.20%) ⬆️
elasticsearch-8.x-v2 1.74% <ø> (ø)
grpc_v1 10.46% <ø> (+0.12%) ⬆️
grpc_v2 1.74% <ø> (ø)
kafka-3.x-v1 9.37% <ø> (+0.11%) ⬆️
kafka-3.x-v2 1.74% <ø> (ø)
memory_v2 1.74% <ø> (ø)
opensearch-1.x-v1 16.90% <ø> (+0.19%) ⬆️
opensearch-2.x-v1 16.90% <ø> (+0.19%) ⬆️
opensearch-2.x-v2 1.74% <ø> (ø)
query 1.74% <ø> (ø)
tailsampling-processor 0.48% <ø> (ø)
unittests 95.43% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yurishkuro yurishkuro added the changelog:refactoring Internal code refactoring without functional changes label Jul 22, 2025
@yurishkuro yurishkuro changed the title Removal of sanitizer/utf8_sanitizer (Dead Code) Remove of sanitizer/utf8_sanitizer (dead code) Jul 22, 2025
@yurishkuro yurishkuro added this pull request to the merge queue Jul 22, 2025
Merged via the queue into jaegertracing:main with commit 0b2dca7 Jul 22, 2025
61 of 62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:refactoring Internal code refactoring without functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants