Skip to content

Removal of all-in-one/setupcontext package (Dead codes) #7359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 23, 2025
Merged

Removal of all-in-one/setupcontext package (Dead codes) #7359

merged 2 commits into from
Jul 23, 2025

Conversation

Parship999
Copy link
Contributor

Which problem is this PR solving?

Description of the changes

  • Files modified:
    • cmd/all-in-one/setupcontext/setupcontext.go
    • cmd/all-in-one/setupcontext/setupcontext_test.go

How was this change tested?

  • go build passes
  • go test passes
  • checked the deadcode, no longer reports these functions
  • no production code was affected

Checklist

@Parship999
rm UnsetAllInOne, IsAllInOne functions
568db7a 
Signed-off-by: Parship Chowdhury <i.am.parship@gmail.com>
@Parship999 Parship999 requested a review from a team as a code owner July 21, 2025 20:02
@Parship999 Parship999 requested a review from albertteoh July 21, 2025 20:02
@codecov Codecov
Copy link

codecov bot commented Jul 21, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.46%. Comparing base (b059cc6) to head (b90ee7d).
Report is 7 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7359      +/-   ##
==========================================
- Coverage   96.47%   96.46%   -0.02%     
==========================================
  Files         378      375       -3     
  Lines       22999    22893     -106     
==========================================
- Hits        22189    22083     -106     
  Misses        613      613              
  Partials      197      197
Flag Coverage Δ
badger_v1 9.18% <ø> (+0.08%) ⬆️
badger_v2 1.74% <ø> (ø)
cassandra-4.x-v1-manual 11.93% <ø> (+0.10%) ⬆️
cassandra-4.x-v2-auto 1.73% <ø> (ø)
cassandra-4.x-v2-manual 1.73% <ø> (ø)
cassandra-5.x-v1-manual 11.93% <ø> (+0.10%) ⬆️
cassandra-5.x-v2-auto 1.73% <ø> (ø)
cassandra-5.x-v2-manual 1.73% <ø> (ø)
elasticsearch-6.x-v1 16.76% <ø> (+0.14%) ⬆️
elasticsearch-7.x-v1 16.80% <ø> (+0.15%) ⬆️
elasticsearch-8.x-v1 16.95% <ø> (+0.15%) ⬆️
elasticsearch-8.x-v2 1.74% <ø> (ø)
grpc_v1 10.43% <ø> (+0.09%) ⬆️
grpc_v2 1.74% <ø> (ø)
kafka-3.x-v1 9.35% <ø> (+0.08%) ⬆️
kafka-3.x-v2 1.74% <ø> (ø)
memory_v2 1.74% <ø> (ø)
opensearch-1.x-v1 16.85% <ø> (+0.15%) ⬆️
opensearch-2.x-v1 16.85% <ø> (+0.15%) ⬆️
opensearch-2.x-v2 1.74% <ø> (ø)
query 1.74% <ø> (ø)
tailsampling-processor 0.48% <ø> (ø)
unittests 95.43% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yurishkuro yurishkuro added the changelog:refactoring Internal code refactoring without functional changes label Jul 22, 2025
yurishkuro
yurishkuro reviewed Jul 22, 2025
View reviewed changes
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need to keep the files/package?

@Parship999
Copy link
Contributor Author

why do we need to keep the files/package?

I was thinking that maybe it was using as an import in many files

@Parship999
all related files and imports removed
b90ee7d 
Signed-off-by: Parship Chowdhury <i.am.parship@gmail.com>
@Parship999 Parship999 requested a review from yurishkuro July 22, 2025 06:47
@yurishkuro yurishkuro added this pull request to the merge queue Jul 22, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 22, 2025
@Parship999
Copy link
Contributor Author

@yurishkuro could you please re-add this pr to the merge queue? Thanks

@yurishkuro yurishkuro added this pull request to the merge queue Jul 23, 2025
Merged via the queue into jaegertracing:main with commit 37bc7e8 Jul 23, 2025
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurishkuro yurishkuro yurishkuro approved these changes

@albertteoh albertteoh Awaiting requested review from albertteoh albertteoh is a code owner automatically assigned from jaegertracing/jaeger-maintainers

Assignees
No one assigned
Labels
changelog:refactoring Internal code refactoring without functional changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Parship999 @yurishkuro