Skip to content

Fix: Store 'blockers' span attribute as string[] in Elasticsearch #7349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: Store 'blockers' span attribute as string[] in Elasticsearch #7349

wants to merge 1 commit into from
+59 −2

Conversation

blazethunderstorm
Copy link

@blazethunderstorm blazethunderstorm commented Jul 19, 2025 •
edited
Loading

Which problem is this PR solving?

Example: Resolves #7346

What does this fix?

  • This fixes a bug where span tags that are lists of words (like ["a", "b"]) were not stored or shown correctly in Jaeger.
  • Now they are saved the right way, so you can see them in the Jaeger UI with no errors.

What did I change?

  • I updated the code to handle tags that are lists of strings.
  • I also changed the HotROD example to use a tag like this so we can test it easily.

How did I test it?

  • I ran HotROD and checked that the tag with the list worked fine.
  • I checked the Jaeger UI and saw no errors.
  • I also ran:
    • make lint test
    • npm run lint and npm run test in jaeger-ui

Checklist

@blazethunderstorm blazethunderstorm requested a review from a team as a code owner July 19, 2025 22:12
graphite-app[bot]
graphite-app bot reviewed Jul 19, 2025
View reviewed changes
@Parship999
Copy link
Contributor

Hi @blazethunderstorm,
I had already mentioned in the comments that I'm working on this issue.

@blazethunderstorm
Copy link
Author

@Parship999 ig anyone can raise pr in jaeger

@Parship999
Copy link
Contributor

@Parship999 ig anyone can raise pr in jaeger

Hi @blazethunderstorm,
jaeger follows an open contribution where anyone can comment and submit a PR, as mentioned in the (https://github.com/jaegertracing/jaeger/blob/main/CONTRIBUTING_GUIDELINES.md#assigning-issues:~:text=Assigning%20Issues,submit%20a%20PR). That said, since i had already expressed intent to work on this issue, i believe it’s good practice to coordinate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

@pavolloffay pavolloffay Awaiting requested review from pavolloffay pavolloffay is a code owner automatically assigned from jaegertracing/jaeger-maintainers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bug storage/elasticsearch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Incorrect storage / retrieval of collection-type attributes
2 participants
@blazethunderstorm @Parship999