Enable automated closing of stale pull requests and issues #7347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Parship Chowdhury <i.am.parship@gmail.com>
yurishkuro
reviewed
Jul 19, 2025
yurishkuro
reviewed
Jul 19, 2025
yurishkuro
reviewed
Jul 21, 2025
yurishkuro
reviewed
Jul 21, 2025
yurishkuro
reviewed
Jul 21, 2025
yurishkuro
reviewed
Jul 21, 2025
Signed-off-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
yurishkuro
reviewed
Jul 21, 2025
Signed-off-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
yurishkuro
reviewed
Jul 21, 2025
Signed-off-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
yurishkuro
approved these changes
Jul 21, 2025
| on: | ||
| schedule: | ||
| # Run every Monday at 1:30 AM UTC | ||
| - cron: '30 1 * * 1' |
There was a problem hiding this comment.
The cron expression 30 1 * * 1 is configured to run weekly on Mondays at 1:30 AM UTC, which doesn't match the PR description stating "schedule daily execution at 1:30 AM UTC". For daily execution, the cron expression should be 30 1 * * * instead.
Suggested change
| - cron: '30 1 * * 1' | |
| - cron: '30 1 * * *' |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
|
@Parship999 I did a test run, looks like it works. Please open another PR to remove the debug flag. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7347 +/- ##
==========================================
- Coverage 96.49% 96.46% -0.03%
==========================================
Files 378 378
Lines 22910 22999 +89
==========================================
+ Hits 22107 22186 +79
- Misses 608 615 +7
- Partials 195 198 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 21, 2025
- continue from #7347 --------- Signed-off-by: Parship Chowdhury <i.am.parship@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
.github/stale.ymlconfiguration was using the deprecated stale app which wasn't working. so it was removedDescription of the changes
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test