[spm] GetCallRate implementation #7229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7229 +/- ##
==========================================
+ Coverage 96.16% 96.19% +0.02%
==========================================
Files 372 374 +2
Lines 22345 22686 +341
==========================================
+ Hits 21488 21822 +334
- Misses 641 645 +4
- Partials 216 219 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi @yurishkuro , the pull request is ready for your review |
00e72db to
7743095
Compare
yurishkuro
reviewed
Jun 20, 2025
yurishkuro
reviewed
Jun 20, 2025
yurishkuro
reviewed
Jun 20, 2025
yurishkuro
reviewed
Jun 20, 2025
yurishkuro
reviewed
Jun 20, 2025
yurishkuro
reviewed
Jun 20, 2025
yurishkuro
reviewed
Jun 20, 2025
internal/storage/metricstore/elasticsearch/testdata/test_call_rate.json
Outdated
Show resolved
Hide resolved
Signed-off-by: pipiland2612 <nguyen.t.dang.minh@gmail.com>
Signed-off-by: pipiland2612 <nguyen.t.dang.minh@gmail.com>
Signed-off-by: pipiland2612 <nguyen.t.dang.minh@gmail.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 1, 2025
## Which problem is this PR solving? - Solve parts of #7243 - Supports #7229 ## 🛑 Breaking change - ES v2 implementation will by default materialize / elevate tags `span.kind` and `span.status` (or `error`) to top level fields in the ES document. - ## How was this change tested? - make lint test ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` --------- Signed-off-by: pipiland2612 <nguyen.t.dang.minh@gmail.com>
Signed-off-by: pipiland2612 <nguyen.t.dang.minh@gmail.com>
8edf36d to
80f85b4
Compare
yurishkuro
reviewed
Jul 2, 2025
yurishkuro
reviewed
Jul 2, 2025
| const ( | ||
| minStep = time.Millisecond | ||
| aggName = "results_buckets" | ||
| searchIndex = "jaeger-span-*" |
There was a problem hiding this comment.
index name can be customized by the user, we should be using the same config as ES storage.
There was a problem hiding this comment.
The current index search search for all index no matter the time range. I think I will solve this problem in W7: Optimisation
yurishkuro
reviewed
Jul 2, 2025
yurishkuro
reviewed
Jul 2, 2025
yurishkuro
reviewed
Jul 2, 2025
| } | ||
|
|
||
| // executeSearch performs the Elasticsearch search. | ||
| func (r MetricsReader) executeSearch(ctx context.Context, p MetricsQueryParams) (*metrics.MetricFamily, error) { |
There was a problem hiding this comment.
I don't like how "hidden" the processing function here, passed via p. Why not simply return the results of the search and call processing function afterwards?
There was a problem hiding this comment.
Hmm, that's make sense. It will make the conversion layer only do it's job converting and we can make the processingFunc to be more transparent in the reader.go
There was a problem hiding this comment.
Solved at 975c4e6
yurishkuro
reviewed
Jul 2, 2025
yurishkuro
reviewed
Jul 2, 2025
yurishkuro
reviewed
Jul 2, 2025
yurishkuro
reviewed
Jul 2, 2025
Signed-off-by: pipiland2612 <nguyen.t.dang.minh@gmail.com>
Signed-off-by: pipiland2612 <nguyen.t.dang.minh@gmail.com>
Signed-off-by: pipiland2612 <nguyen.t.dang.minh@gmail.com>
Signed-off-by: pipiland2612 <nguyen.t.dang.minh@gmail.com>
7f7fa47 to
975c4e6
Compare
Signed-off-by: pipiland2612 <nguyen.t.dang.minh@gmail.com>
yurishkuro
approved these changes
Jul 2, 2025
| } | ||
|
|
||
| // executeSearch performs the Elasticsearch search. | ||
| func (r MetricsReader) executeSearch(ctx context.Context, p MetricsQueryParams) (*metrics.MetricFamily, error) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
How was this change tested?
Proof of this new feature
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test