Add skeleton implementation for ES as metricstorage for SPM #7209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…icsearch metrics_backend Signed-off-by: pipiland2612 <nguyen.t.dang.minh@gmail.com>
3eea0c4 to
b41a8a9
Compare
Signed-off-by: pipiland2612 <nguyen.t.dang.minh@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7209 +/- ##
==========================================
- Coverage 96.19% 96.15% -0.05%
==========================================
Files 366 368 +2
Lines 21962 22009 +47
==========================================
+ Hits 21127 21163 +36
- Misses 624 632 +8
- Partials 211 214 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: pipiland2612 <nguyen.t.dang.minh@gmail.com>
Signed-off-by: pipiland2612 <nguyen.t.dang.minh@gmail.com>
Signed-off-by: pipiland2612 <nguyen.t.dang.minh@gmail.com>
…ge/extension_test.go Signed-off-by: pipiland2612 <nguyen.t.dang.minh@gmail.com>
|
Hi @yurishkuro, the pull request is ready for your review |
yurishkuro
reviewed
Jun 9, 2025
yurishkuro
reviewed
Jun 9, 2025
Signed-off-by: pipiland2612 <nguyen.t.dang.minh@gmail.com>
Signed-off-by: pipiland2612 <nguyen.t.dang.minh@gmail.com>
501e2fb to
631d428
Compare
Signed-off-by: pipiland2612 <nguyen.t.dang.minh@gmail.com>
Signed-off-by: pipiland2612 <nguyen.t.dang.minh@gmail.com>
yurishkuro
reviewed
Jun 9, 2025
yurishkuro
reviewed
Jun 9, 2025
yurishkuro
reviewed
Jun 9, 2025
yurishkuro
reviewed
Jun 9, 2025
yurishkuro
reviewed
Jun 9, 2025
|
Hi @yurishkuro , the pr is ready for your review |
yurishkuro
reviewed
Jun 10, 2025
Signed-off-by: pipiland2612 <nguyen.t.dang.minh@gmail.com>
Signed-off-by: pipiland2612 <nguyen.t.dang.minh@gmail.com>
Signed-off-by: pipiland2612 <nguyen.t.dang.minh@gmail.com>
9b6d6d9 to
3da71dd
Compare
|
@pipiland2612 please give descriptive title to the PRs |
|
Sure, thank you for remind me! |
yurishkuro
reviewed
Jun 10, 2025
Signed-off-by: pipiland2612 <nguyen.t.dang.minh@gmail.com>
|
Hi @yurishkuro , could you please give me a review? That would be so nice then I can continue my work with W3 |
yurishkuro
reviewed
Jun 10, 2025
yurishkuro
approved these changes
Jun 10, 2025
|
Thank you for your support! I really appreciate it |
Comment on lines
+12
to
+13
| traces: elasticsearch_trace_storage | ||
| metrics: elasticsearch_trace_storage |
There was a problem hiding this comment.
The configuration references elasticsearch_trace_storage for both traces and metrics storage, but this identifier is only defined in the backends section for trace storage. For metrics, it should reference an identifier defined in the metric_backends section. Please update line 13 to use the same identifier that's defined in the metric_backends section (lines 20-24) to ensure proper configuration mapping.
Suggested change
| traces: elasticsearch_trace_storage | |
| metrics: elasticsearch_trace_storage | |
| traces: elasticsearch_trace_storage | |
| metrics: elasticsearch_metrics_storage |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test