Refactor metricstore/es/reader.go by introducing queryBuilder #7297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pipiland2612 <nguyen.t.dang.minh@gmail.com>
Signed-off-by: pipiland2612 <nguyen.t.dang.minh@gmail.com>
yurishkuro
approved these changes
Jul 6, 2025
pipiland2612
commented
Jul 6, 2025
|
|
||
| // These constants define the specific names of aggregations used within Elasticsearch | ||
| // queries. They are crucial for both constructing the query sent to Elasticsearch | ||
| // and for correctly extracting the corresponding data from the Elasticsearch response. |
There was a problem hiding this comment.
Hi @yurishkuro, since these constants are also important for retrieve results from raw ES result, they can also be used in another file (to_domain.go, reader.go)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7297 +/- ##
==========================================
- Coverage 96.18% 96.16% -0.02%
==========================================
Files 374 375 +1
Lines 22750 22733 -17
==========================================
- Hits 21882 21862 -20
- Misses 655 657 +2
- Partials 213 214 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test