Skip to content

Refactor metricstore/elasticsearch/reader.go #7295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 5, 2025
Merged

Refactor metricstore/elasticsearch/reader.go #7295

merged 6 commits into from
Jul 5, 2025

Conversation

pipiland2612
Copy link
Contributor

@pipiland2612 pipiland2612 commented Jul 4, 2025 •
edited
Loading

Which problem is this PR solving?

Description of the changes

  • Refactor reader.go

How was this change tested?

  • make lint test

Checklist

@pipiland2612
Refactor getcallrate
eb078ed 
Signed-off-by: pipiland2612 <nguyen.t.dang.minh@gmail.com>
@pipiland2612
Remove lambda inside metricsQueryParams
c904692 
Signed-off-by: pipiland2612 <nguyen.t.dang.minh@gmail.com>
@pipiland2612
Fix comment
3651901 
Signed-off-by: pipiland2612 <nguyen.t.dang.minh@gmail.com>
@pipiland2612 pipiland2612 requested a review from a team as a code owner July 4, 2025 21:07
@pipiland2612 pipiland2612 requested a review from mahadzaryab1 July 4, 2025 21:07
@pipiland2612 pipiland2612 changed the title Refactor get call rate Refactor metricstore/elasticsearch/reader.go Jul 4, 2025
@pipiland2612 pipiland2612 mentioned this pull request Jul 4, 2025
Merged
4 tasks
@codecov Codecov
Copy link

codecov bot commented Jul 4, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 96.93878% with 3 lines in your changes missing coverage. Please review.

Project coverage is 96.14%. Comparing base (d321ea3) to head (2073a82).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ternal/storage/metricstore/elasticsearch/reader.go 96.38% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #7295   +/-   ##
=======================================
  Coverage   96.14%   96.14%           
=======================================
  Files         374      374           
  Lines       22693    22696    +3     
=======================================
+ Hits        21818    21822    +4     
  Misses        659      659           
+ Partials      216      215    -1
Flag Coverage Δ
badger_v1 9.03% <ø> (ø)
badger_v2 1.78% <0.00%> (-0.01%) ⬇️
cassandra-4.x-v1-manual 11.93% <ø> (ø)
cassandra-4.x-v2-auto 1.77% <0.00%> (-0.01%) ⬇️
cassandra-4.x-v2-manual 1.77% <0.00%> (-0.01%) ⬇️
cassandra-5.x-v1-manual 11.93% <ø> (ø)
cassandra-5.x-v2-auto 1.77% <0.00%> (-0.01%) ⬇️
cassandra-5.x-v2-manual 1.77% <0.00%> (-0.01%) ⬇️
elasticsearch-6.x-v1 16.69% <ø> (ø)
elasticsearch-7.x-v1 16.73% <ø> (ø)
elasticsearch-8.x-v1 16.89% <ø> (ø)
elasticsearch-8.x-v2 1.78% <0.00%> (-0.10%) ⬇️
grpc_v1 10.43% <ø> (ø)
grpc_v2 1.78% <0.00%> (-0.01%) ⬇️
kafka-3.x-v1 9.35% <ø> (ø)
kafka-3.x-v2 1.78% <0.00%> (-0.01%) ⬇️
memory_v2 1.78% <0.00%> (-0.01%) ⬇️
opensearch-1.x-v1 16.78% <ø> (ø)
opensearch-2.x-v1 16.78% <ø> (ø)
opensearch-2.x-v2 1.78% <0.00%> (-0.01%) ⬇️
query 1.78% <0.00%> (-0.01%) ⬇️
tailsampling-processor 0.49% <0.00%> (-0.01%) ⬇️
unittests 95.06% <96.93%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pipiland2612
Add new test
68c29f5 
Signed-off-by: pipiland2612 <nguyen.t.dang.minh@gmail.com>
@pipiland2612 pipiland2612 force-pushed the refactor_getCallRate branch from 39d7cea to 68c29f5 Compare July 4, 2025 21:25
graphite-app[bot]
graphite-app bot reviewed Jul 4, 2025
View reviewed changes
@pipiland2612
Copy link
Contributor Author

Hi @yurishkuro, I think the pr is ready for your review.

@yurishkuro yurishkuro added the changelog:exprimental Change to an experimental part of the code label Jul 4, 2025
yurishkuro
yurishkuro reviewed Jul 4, 2025
View reviewed changes
yurishkuro
yurishkuro reviewed Jul 4, 2025
View reviewed changes
yurishkuro
yurishkuro reviewed Jul 4, 2025
View reviewed changes
yurishkuro
yurishkuro reviewed Jul 4, 2025
View reviewed changes
yurishkuro
yurishkuro reviewed Jul 4, 2025
View reviewed changes
@pipiland2612
Rename method
36c1826 
Signed-off-by: pipiland2612 <nguyen.t.dang.minh@gmail.com>
@pipiland2612
simplify bucketToPoints
2073a82 
Signed-off-by: pipiland2612 <nguyen.t.dang.minh@gmail.com>
@pipiland2612 pipiland2612 requested a review from yurishkuro July 5, 2025 07:35
@pipiland2612
Copy link
Contributor Author

Hi @yurishkuro, the pr is ready for your review. Thanks for your support !

@yurishkuro yurishkuro added this pull request to the merge queue Jul 5, 2025
Merged via the queue into jaegertracing:main with commit 10e7ea9 Jul 5, 2025
60 checks passed
@pipiland2612 pipiland2612 deleted the refactor_getCallRate branch July 5, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

@yurishkuro yurishkuro yurishkuro approved these changes

@mahadzaryab1 mahadzaryab1 Awaiting requested review from mahadzaryab1 mahadzaryab1 is a code owner automatically assigned from jaegertracing/jaeger-maintainers

Assignees
No one assigned
Labels
changelog:exprimental Change to an experimental part of the code storage/elasticsearch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pipiland2612 @yurishkuro