Jaeger Demo on Kubernetes #7262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
examples/oci/README.md
Outdated
| git clone https://github.com/jaegertracing/helm-charts.git | ||
| cd helm-charts | ||
| git checkout v2 | ||
| ```` |
There was a problem hiding this comment.
The code block delimiter is inconsistent with the rest of the document. Please use triple backticks (```) instead of quadruple backticks (````) to maintain consistent formatting throughout the documentation.
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7262 +/- ##
=======================================
Coverage 96.18% 96.18%
=======================================
Files 369 369
Lines 22187 22187
=======================================
Hits 21341 21341
Misses 632 632
Partials 214 214
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Draft looks good aside from what the bot pointed out where you have a typo. I did not test it since I do not have a cluster on this machine. |
…gertracing#7257) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/prometheus/common](https://redirect.github.com/prometheus/common) | `v0.64.0` -> `v0.65.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- <details> <summary>prometheus/common (github.com/prometheus/common)</summary> [`v0.65.0`](https://redirect.github.com/prometheus/common/releases/tag/v0.65.0) [Compare Source](https://redirect.github.com/prometheus/common/compare/v0.64.0...v0.65.0) - Synchronize common files from prometheus/prometheus by [@​prombot](https://redirect.github.com/prombot) in [https://github.com/prometheus/common/pull/789](https://redirect.github.com/prometheus/common/pull/789) - Remove otlptranslator package by [@​ArthurSens](https://redirect.github.com/ArthurSens) in [https://github.com/prometheus/common/pull/791](https://redirect.github.com/prometheus/common/pull/791) - feat(promslog): add Level() method to get slog.Level by [@​tjhop](https://redirect.github.com/tjhop) in [https://github.com/prometheus/common/pull/795](https://redirect.github.com/prometheus/common/pull/795) - feat: Support negative duration in new function ParseDurationAllowNegative by [@​iamhalje](https://redirect.github.com/iamhalje) in [https://github.com/prometheus/common/pull/793](https://redirect.github.com/prometheus/common/pull/793) - [@​iamhalje](https://redirect.github.com/iamhalje) made their first contribution in [https://github.com/prometheus/common/pull/793](https://redirect.github.com/prometheus/common/pull/793) **Full Changelog**: prometheus/common@v0.64.0...v0.65.0 </details> --- 📅 **Schedule**: Branch creation - "on the first day of the month" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/jaegertracing/jaeger). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MC42Mi4xIiwidXBkYXRlZEluVmVyIjoiNDAuNjIuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiY2hhbmdlbG9nOmRlcGVuZGVuY2llcyJdfQ==--> Signed-off-by: Mend Renovate <bot@renovateapp.com>
3d28c46 to
1d6b19f
Compare
Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com>
Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com>
yurishkuro
reviewed
Jun 27, 2025
| Create a ConfigMap to mount the Prometheus configuration: | ||
|
|
||
| ```bash | ||
| kubectl create configmap prometheus-config --from-file=prometheus.yml=./prometheus.yml |
There was a problem hiding this comment.
so my question would be - are you expecting maintainers to do all these steps manually when deploying to OCI? Ideally I don't even want to think about the deployment, they should happen automatically when a new Jaeger version is released. How do we plan to achieve that? Let's work backwards from this ideal state.
There was a problem hiding this comment.
I forgot to mention this in the PR description: my initial goal was to get the setup working locally first. We can then iteratively automate the entire process in subsequent PRs.
| cd helm-charts | ||
| git checkout v2 | ||
| ``` | ||
| After cloning, you must install chart dependencies to avoid the depedency missing error using this command : |
There was a problem hiding this comment.
There's a small typo in this line: "depedency" should be spelled "dependency".
Suggested change
| After cloning, you must install chart dependencies to avoid the depedency missing error using this command : | |
| After cloning, you must install chart dependencies to avoid the dependency missing error using this command : |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ClusterIPtoLoadBalancer) with other production practices are still required for production readiness. These will be addressed in upcoming PRs.Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test