Add retries to ILM client #7120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ee9eef8 to
3ccc1ea
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a flaky test by introducing retry logic with exponential backoff in the ILMClient.Exists method. The changes aim to improve resilience against transient network issues.
- Added a test (TestExists_Retries) to verify the retry behavior.
- Implemented exponential backoff retry logic in the ILMClient.Exists method.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/storage/elasticsearch/client/ilm_client.go | Added retry loop with exponential backoff for Exists |
| internal/storage/elasticsearch/client/ilm_client_test.go | Introduced a new unit test to validate retry logic |
377cd99 to
0695551
Compare
yurishkuro
approved these changes
May 17, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7120 +/- ##
==========================================
- Coverage 96.20% 96.19% -0.02%
==========================================
Files 362 362
Lines 21853 21868 +15
==========================================
+ Hits 21024 21036 +12
- Misses 620 622 +2
- Partials 209 210 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
97dcaad to
4046f17
Compare
yurishkuro
reviewed
May 20, 2025
988991f to
e996f54
Compare
yurishkuro
approved these changes
May 20, 2025
…efix,_[ROLLOVER=true] (jaegertracing#6838) Signed-off-by: Ilia Yavorov Petrov <ilia.yavorov.petrov@gmail.com> Signed-off-by: Ilia Petrov <ilia.yavorov.petrov@gmail.com>
…/cenkalti/backoff/v5 Signed-off-by: Ilia Petrov <ilia.yavorov.petrov@gmail.com>
Signed-off-by: Ilia Petrov <ilia.yavorov.petrov@gmail.com>
auto-merge was automatically disabled
May 21, 2025 04:10
Head branch was pushed to by a user without write access
5bdecc6 to
26b58f3
Compare
|
need to run |
Signed-off-by: Ilia Petrov <ilia.yavorov.petrov@gmail.com>
Signed-off-by: Ilia Petrov <ilia.yavorov.petrov@gmail.com>
c033f6b to
dc8374a
Compare
yurishkuro
approved these changes
May 22, 2025
…move_rollover-indices_prefix-rollover-true
Signed-off-by: Ilia Petrov <ilia.yavorov.petrov@gmail.com>
3f0a99b to
d81cad9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test