Skip to content

[refactor] Remove archive storage from gRPC config #7113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 12, 2025
Merged

[refactor] Remove archive storage from gRPC config #7113

merged 2 commits into from
May 12, 2025

Conversation

mahadzaryab1
Copy link
Collaborator

Which problem is this PR solving?

Description of the changes

  • Removes the archive storage from the gRPC config as it is not being used in the integration test setup

How was this change tested?

  • CI

Checklist

@mahadzaryab1
Remove Archive From gRPC Integration Test
a6f6178 
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
@mahadzaryab1 mahadzaryab1 requested a review from yurishkuro May 12, 2025 00:27
@mahadzaryab1 mahadzaryab1 requested a review from a team as a code owner May 12, 2025 00:27
@mahadzaryab1 mahadzaryab1 added the changelog:refactoring Internal code refactoring without functional changes label May 12, 2025
@dosubot dosubot bot added the area/storage label May 12, 2025
yurishkuro
yurishkuro reviewed May 12, 2025
View reviewed changes
@mahadzaryab1
Remove Whitelist
4138b31 
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
@mahadzaryab1 mahadzaryab1 enabled auto-merge May 12, 2025 00:33
@codecov Codecov
Copy link

codecov bot commented May 12, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.13%. Comparing base (5edb4fb) to head (4138b31).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7113      +/-   ##
==========================================
+ Coverage   96.09%   96.13%   +0.03%     
==========================================
  Files         358      358              
  Lines       21585    21585              
==========================================
+ Hits        20742    20750       +8     
+ Misses        635      629       -6     
+ Partials      208      206       -2
Flag Coverage Δ
badger_v1 9.91% <ø> (ø)
badger_v2 2.05% <ø> (ø)
cassandra-4.x-v1-manual 14.91% <ø> (ø)
cassandra-4.x-v2-auto 2.04% <ø> (ø)
cassandra-4.x-v2-manual 2.04% <ø> (ø)
cassandra-5.x-v1-manual 14.91% <ø> (ø)
cassandra-5.x-v2-auto 2.04% <ø> (ø)
cassandra-5.x-v2-manual 2.04% <ø> (ø)
elasticsearch-6.x-v1 20.17% <ø> (ø)
elasticsearch-7.x-v1 20.25% <ø> (ø)
elasticsearch-8.x-v1 20.43% <ø> (ø)
elasticsearch-8.x-v2 2.05% <ø> (ø)
grpc_v1 11.46% <ø> (ø)
grpc_v2 2.05% <ø> (ø)
kafka-3.x-v1 10.19% <ø> (ø)
kafka-3.x-v2 2.05% <ø> (ø)
memory_v2 2.05% <ø> (ø)
opensearch-1.x-v1 20.30% <ø> (ø)
opensearch-2.x-v1 20.30% <ø> (ø)
opensearch-2.x-v2 2.05% <ø> (ø)
query 2.05% <ø> (ø)
tailsampling-processor 0.55% <ø> (ø)
unittests 94.94% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mahadzaryab1 mahadzaryab1 added this pull request to the merge queue May 12, 2025
Merged via the queue into jaegertracing:main with commit 67e6470 May 12, 2025
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurishkuro yurishkuro yurishkuro approved these changes

Assignees
No one assigned
Labels
area/storage changelog:refactoring Internal code refactoring without functional changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mahadzaryab1 @yurishkuro