[fix] Propagate environment variables to binary from integration tests #7112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7112 +/- ##
==========================================
- Coverage 96.13% 96.09% -0.04%
==========================================
Files 358 358
Lines 21585 21585
==========================================
- Hits 20750 20742 -8
- Misses 629 635 +6
- Partials 206 208 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yurishkuro
reviewed
May 10, 2025
| @@ -89,7 +89,7 @@ func (s *E2EStorageIntegration) e2eInitialize(t *testing.T, storage string) { | |||
| // since the binary config file jaeger_query's ui.config_file points to | |||
| // "./cmd/jaeger/config-ui.json" | |||
| Dir: "../../../..", | |||
| Env: envVars, | |||
| Env: append(os.Environ(), envVars...), | |||
There was a problem hiding this comment.
I am not sure we want such a blanket copy, I would rather use some kind of whitelist of env vars that should be propagated, and have that list controlled by the individual tests (i.e. empty by default)
There was a problem hiding this comment.
@yurishkuro Addressed. Let me know what you think
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
yurishkuro
reviewed
May 10, 2025
| PropagateEnvVars: []string{ | ||
| "REMOTE_STORAGE_ENDPOINT", | ||
| "ARCHIVE_REMOTE_STORAGE_ENDPOINT", | ||
| }, |
There was a problem hiding this comment.
we need to add a var for writer endpoint
endpoint: "${env:REMOTE_STORAGE_ENDPOINT:-localhost:17271}"
tls:
insecure: true
writer:
endpoint: 0.0.0.0:4316
tls:
insecure: true
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
yurishkuro
approved these changes
May 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
How was this change tested?
go testChecklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test