[refactor] Use proto files from jaeger-idl for remote storage API
#7104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
mahadzaryab1
commented
May 6, 2025
| @@ -1,11 +1,13 @@ | |||
| s|import "google/protobuf/duration.proto";|import "google/protobuf/duration.proto";\ | |||
| 0,/import "google\/protobuf\/.*.proto";/{ | |||
There was a problem hiding this comment.
Needed to slightly refactor this because dependency_storage.proto was importing gogoproto/gogo.proto which we don't want in the interface definition.
There was a problem hiding this comment.
dependency_storage.proto was importing gogoproto/gogo.proto
does it still do that in idl? We shouldn't include gogo in public proto files
There was a problem hiding this comment.
@yurishkuro No it doesn't - I removed it. That's why the changes were needed here
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7104 +/- ##
==========================================
- Coverage 96.11% 96.10% -0.01%
==========================================
Files 358 358
Lines 21585 21585
==========================================
- Hits 20747 20745 -2
- Misses 631 633 +2
Partials 207 207
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yurishkuro
approved these changes
May 7, 2025
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
yurishkuro
approved these changes
May 7, 2025
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
yurishkuro
approved these changes
May 7, 2025
yurishkuro
previously approved these changes
May 9, 2025
|
please don't merge until we do a release |
yurishkuro
approved these changes
May 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
trace_storage.protoanddependency_storage.protoand use the ones fromjaeger-idlinsteadHow was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test