Skip to content

Pin testify version to 1.2.1 #710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 22, 2018
Merged

Pin testify version to 1.2.1 #710

merged 2 commits into from
Feb 22, 2018

Conversation

pavolloffay
Copy link
Member

@pavolloffay
Pin testify version to 1.2.1
960b6f1 
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
@ghost ghost assigned pavolloffay Feb 22, 2018
@ghost ghost added the review label Feb 22, 2018
@yurishkuro
Copy link
Member

+1 to start using a version, but why pin instead of ^1.2.1?

@pavolloffay
Use ^
fa2b8ec 
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
@pavolloffay
Copy link
Member Author

No reason, updated

@coveralls
Copy link

coveralls commented Feb 22, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling fa2b8ec on pavolloffay:pin-testify-version into 2557fa1 on jaegertracing:master.

@yurishkuro yurishkuro merged commit b1d39bb into jaegertracing:master Feb 22, 2018
@ghost ghost removed the review label Feb 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurishkuro yurishkuro yurishkuro approved these changes

@black-adder black-adder Awaiting requested review from black-adder

@vprithvi vprithvi Awaiting requested review from vprithvi

Assignees

@pavolloffay pavolloffay

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pavolloffay @yurishkuro @coveralls