Skip to content

Relocate the docker directory from the root directory to under scripts/build #7189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 1, 2025
Merged

Relocate the docker directory from the root directory to under scripts/build #7189

merged 4 commits into from
Jun 1, 2025

Conversation

ris-tlp
Copy link
Contributor

@ris-tlp ris-tlp commented Jun 1, 2025

Which problem is this PR solving?

Description of the changes

  • The docker/ directory has been moved to scripts/build/ as requested in the issue.
  • All references of docker/ have been updated to point to the new path.

How was this change tested?

  • Ran the create-baseimg, create-debugimg, and create-fake-debugimage in scripts/makefiles/Docker.mk manually until successful completion.
  • Ran the scripts/lint/check-go-version.sh shell script until successful completion.
  • Ensured go files funder docker/debug/ weren't affected by auto-formatting and linting.

Checklist

ris-tlp added 4 commits June 1, 2025 00:49
@ris-tlp
Move docker dir from root dir to scripts/build/
9c25902 
Signed-off-by: Omar Khan <omarkhantlp@gmail.com>
@ris-tlp
Point references in Docker.mk to new docker dir path
22bf127 
Signed-off-by: Omar Khan <omarkhantlp@gmail.com>
@ris-tlp
Update docker dir path in ALL_SRC var
84e6d41 
Signed-off-by: Omar Khan <omarkhantlp@gmail.com>
@ris-tlp
Update docker dir path
37db280 
Signed-off-by: Omar Khan <omarkhantlp@gmail.com>
@ris-tlp ris-tlp requested a review from a team as a code owner June 1, 2025 05:22
@ris-tlp ris-tlp requested a review from joe-elliott June 1, 2025 05:22
@dosubot dosubot bot added the docker Pull requests that update Docker code label Jun 1, 2025
@yurishkuro yurishkuro added the changelog:refactoring Internal code refactoring without functional changes label Jun 1, 2025
@codecov Codecov
Copy link

codecov bot commented Jun 1, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.19%. Comparing base (e598691) to head (37db280).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7189      +/-   ##
==========================================
- Coverage   96.21%   96.19%   -0.03%     
==========================================
  Files         365      365              
  Lines       21964    21964              
==========================================
- Hits        21133    21128       -5     
- Misses        621      625       +4     
- Partials      210      211       +1
Flag Coverage Δ
badger_v1 9.85% <ø> (ø)
badger_v2 1.90% <ø> (ø)
cassandra-4.x-v1-manual 14.82% <ø> (ø)
cassandra-4.x-v2-auto 1.89% <ø> (ø)
cassandra-4.x-v2-manual 1.89% <ø> (ø)
cassandra-5.x-v1-manual 14.82% <ø> (ø)
cassandra-5.x-v2-auto 1.89% <ø> (ø)
cassandra-5.x-v2-manual 1.89% <ø> (ø)
elasticsearch-6.x-v1 20.65% <ø> (ø)
elasticsearch-7.x-v1 20.73% <ø> (ø)
elasticsearch-8.x-v1 20.90% <ø> (ø)
elasticsearch-8.x-v2 1.90% <ø> (ø)
grpc_v1 11.39% <ø> (ø)
grpc_v2 1.90% <ø> (ø)
kafka-3.x-v1 10.20% <ø> (ø)
kafka-3.x-v2 1.90% <ø> (ø)
memory_v2 1.90% <ø> (ø)
opensearch-1.x-v1 20.78% <ø> (ø)
opensearch-2.x-v1 20.78% <ø> (ø)
opensearch-2.x-v2 1.90% <ø> (ø)
query 1.90% <ø> (ø)
tailsampling-processor 0.51% <ø> (ø)
unittests 95.01% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

yurishkuro
yurishkuro approved these changes Jun 1, 2025
View reviewed changes
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yurishkuro yurishkuro added this pull request to the merge queue Jun 1, 2025
Merged via the queue into jaegertracing:main with commit 0433c82 Jun 1, 2025
60 of 62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurishkuro yurishkuro yurishkuro approved these changes

@joe-elliott joe-elliott Awaiting requested review from joe-elliott joe-elliott is a code owner automatically assigned from jaegertracing/jaeger-maintainers

Assignees
No one assigned
Labels
changelog:refactoring Internal code refactoring without functional changes docker Pull requests that update Docker code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Relocate docker/ folder from root of the project
2 participants
@ris-tlp @yurishkuro