Skip to content

[clickhouse] Implement GetOperations for trace reader in ClickHouse storage #7180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 30, 2025
Merged

[clickhouse] Implement GetOperations for trace reader in ClickHouse storage #7180

merged 6 commits into from
May 30, 2025

Conversation

mahadzaryab1
Copy link
Collaborator

@mahadzaryab1 mahadzaryab1 commented May 28, 2025 •
edited
Loading

Which problem is this PR solving?

Description of the changes

  • Implemented a function to get operations from ClickHouse storage.

How was this change tested?

  • Added unit tests

Checklist

@mahadzaryab1
Add Database Type For Operation
2e2ef8e 
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
@mahadzaryab1
Add Function To Get Operations
913876a 
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
mahadzaryab1
mahadzaryab1 commented May 28, 2025
View reviewed changes
@mahadzaryab1 mahadzaryab1 added the changelog:exprimental Change to an experimental part of the code label May 28, 2025
@codecov Codecov
Copy link

codecov bot commented May 28, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.20%. Comparing base (a7c26c5) to head (6e5290c).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7180      +/-   ##
==========================================
- Coverage   96.22%   96.20%   -0.02%     
==========================================
  Files         365      365              
  Lines       21940    21964      +24     
==========================================
+ Hits        21112    21131      +19     
- Misses        619      623       +4     
- Partials      209      210       +1
Flag Coverage Δ
badger_v1 9.85% <ø> (ø)
badger_v2 1.90% <ø> (ø)
cassandra-4.x-v1-manual 14.82% <ø> (ø)
cassandra-4.x-v2-auto 1.89% <ø> (ø)
cassandra-4.x-v2-manual 1.89% <ø> (ø)
cassandra-5.x-v1-manual 14.82% <ø> (ø)
cassandra-5.x-v2-auto 1.89% <ø> (ø)
cassandra-5.x-v2-manual 1.89% <ø> (ø)
elasticsearch-6.x-v1 20.65% <ø> (ø)
elasticsearch-7.x-v1 20.73% <ø> (ø)
elasticsearch-8.x-v1 20.90% <ø> (ø)
elasticsearch-8.x-v2 1.90% <ø> (ø)
grpc_v1 11.39% <ø> (ø)
grpc_v2 1.90% <ø> (ø)
kafka-3.x-v1 10.20% <ø> (ø)
kafka-3.x-v2 1.90% <ø> (ø)
memory_v2 1.90% <ø> (ø)
opensearch-1.x-v1 20.78% <ø> (ø)
opensearch-2.x-v1 20.78% <ø> (ø)
opensearch-2.x-v2 1.90% <ø> (ø)
query 1.90% <ø> (ø)
tailsampling-processor 0.51% <ø> (ø)
unittests 95.03% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mahadzaryab1
Add Check For Empty SpanKind
905550b 
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
@mahadzaryab1
Add Unit Tests
ca5e3c0 
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
@mahadzaryab1
Fix
11c9548 
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
@mahadzaryab1
Add Query Check
6e5290c 
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
@mahadzaryab1 mahadzaryab1 marked this pull request as ready for review May 29, 2025 23:23
@mahadzaryab1 mahadzaryab1 requested a review from a team as a code owner May 29, 2025 23:23
@mahadzaryab1 mahadzaryab1 requested a review from jkowall May 29, 2025 23:23
@yurishkuro yurishkuro added this pull request to the merge queue May 30, 2025
Merged via the queue into jaegertracing:main with commit e598691 May 30, 2025
83 of 84 checks passed
@mahadzaryab1 mahadzaryab1 mentioned this pull request May 30, 2025
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurishkuro yurishkuro yurishkuro approved these changes

@jkowall jkowall Awaiting requested review from jkowall jkowall is a code owner automatically assigned from jaegertracing/jaeger-maintainers

Assignees
No one assigned
Labels
area/storage changelog:exprimental Change to an experimental part of the code enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mahadzaryab1 @yurishkuro