fix(elasticsearch): respect explicitly configured replicas=0 in index… #7160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please sign the commits and make sure |
yurishkuro
reviewed
May 29, 2025
I'm currently going through the rest of the code to update all uses of Replicas to handle *int64 properly. |
… options Signed-off-by: Masih Khatibzadeh <masih78khatibzadeh@gmail.com>
Signed-off-by: Masih Khatibzadeh <masih78khatibzadeh@gmail.com>
24454ac to
3a83f02
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7160 +/- ##
==========================================
- Coverage 96.21% 96.18% -0.03%
==========================================
Files 361 366 +5
Lines 21836 21962 +126
==========================================
+ Hits 21009 21124 +115
- Misses 618 626 +8
- Partials 209 212 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yurishkuro
reviewed
Jun 1, 2025
yurishkuro
reviewed
Jun 1, 2025
yurishkuro
reviewed
Jun 1, 2025
Signed-off-by: Masih Khatibzadeh <masih78khatibzadeh@gmail.com>
20de8c9 to
b018d6b
Compare
yurishkuro
reviewed
Jun 6, 2025
Signed-off-by: Masih Khatibzadeh <masih78khatibzadeh@gmail.com>
yurishkuro
approved these changes
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, replicas set to 0 in the OpenTelemetryCollector config
would be overwritten by default values.
This commit updates the IndexOptions struct to use a pointer type for
Replicasand adjusts the defaulting logic to only apply defaults whenReplicasis nil. This allows users to explicitly configurereplicas: 0without being ignored.Reesolves #7123