Skip to content

Conversation

Manik2708
Copy link
Contributor

Which problem is this PR solving?

Description of the changes

  • Implement GetOperations and GetServices for v2 for ES/OS

How was this change tested?

  • Unit Tests

Checklist

Signed-off-by: Manik2708 <mehtamanik96@gmail.com>
@Manik2708 Manik2708 requested a review from a team as a code owner April 14, 2025 02:52
@Manik2708 Manik2708 requested a review from mahadzaryab1 April 14, 2025 02:52
Copy link

codecov bot commented Apr 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.00%. Comparing base (fb4bbf7) to head (8af9916).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7025   +/-   ##
=======================================
  Coverage   96.00%   96.00%           
=======================================
  Files         347      348    +1     
  Lines       20626    20654   +28     
=======================================
+ Hits        19801    19829   +28     
  Misses        622      622           
  Partials      203      203           
Flag Coverage Δ
badger_v1 10.48% <ø> (ø)
badger_v2 2.17% <ø> (ø)
cassandra-4.x-v1-manual 15.77% <ø> (ø)
cassandra-4.x-v2-auto 2.16% <ø> (ø)
cassandra-4.x-v2-manual 2.16% <ø> (ø)
cassandra-5.x-v1-manual 15.77% <ø> (ø)
cassandra-5.x-v2-auto 2.16% <ø> (ø)
cassandra-5.x-v2-manual 2.16% <ø> (ø)
elasticsearch-6.x-v1 20.88% <ø> (ø)
elasticsearch-7.x-v1 20.96% <ø> (ø)
elasticsearch-8.x-v1 21.14% <ø> (ø)
elasticsearch-8.x-v2 2.29% <ø> (+0.11%) ⬆️
grpc_v1 11.56% <ø> (ø)
grpc_v2 8.43% <ø> (ø)
kafka-3.x-v1 10.78% <ø> (ø)
kafka-3.x-v2 2.17% <ø> (ø)
memory_v2 2.17% <ø> (ø)
opensearch-1.x-v1 21.01% <ø> (ø)
opensearch-2.x-v1 21.01% <ø> (ø)
opensearch-2.x-v2 2.17% <ø> (ø)
tailsampling-processor 0.59% <ø> (ø)
unittests 94.81% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yurishkuro yurishkuro enabled auto-merge April 14, 2025 16:43
@yurishkuro yurishkuro added the changelog:exprimental Change to an experimental part of the code label Apr 14, 2025
@yurishkuro yurishkuro added this pull request to the merge queue Apr 14, 2025
Merged via the queue into jaegertracing:main with commit 99c84ce Apr 14, 2025
56 of 59 checks passed
amilbcahat pushed a commit to amilbcahat/jaeger that referenced this pull request May 4, 2025
…acing#7025)

## Which problem is this PR solving?
-  Fixes a part of: jaegertracing#6458 

## Description of the changes
- Implement `GetOperations` and `GetServices` for v2 for ES/OS

## How was this change tested?
- Unit Tests

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [x] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `npm run lint` and `npm run test`

Signed-off-by: Manik2708 <mehtamanik96@gmail.com>
amilbcahat pushed a commit to amilbcahat/jaeger that referenced this pull request May 4, 2025
…acing#7025)

## Which problem is this PR solving?
-  Fixes a part of: jaegertracing#6458

## Description of the changes
- Implement `GetOperations` and `GetServices` for v2 for ES/OS

## How was this change tested?
- Unit Tests

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [x] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `npm run lint` and `npm run test`

Signed-off-by: Manik2708 <mehtamanik96@gmail.com>
Signed-off-by: amol-verma-allen <amol.verma@allen.in>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/storage changelog:exprimental Change to an experimental part of the code v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants