[refactor] Change remote storage server to accept v2 factories #7024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7024 +/- ##
==========================================
- Coverage 96.00% 95.99% -0.01%
==========================================
Files 347 349 +2
Lines 20626 20666 +40
==========================================
+ Hits 19801 19838 +37
- Misses 622 624 +2
- Partials 203 204 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
b1d9abd to
e2afab9
Compare
mahadzaryab1
commented
Apr 15, 2025
| server, err := app.NewServer(opts, storageFactory, tm, telset) | ||
|
|
||
| traceFactory := v1adapter.NewFactory(storageFactory) | ||
| depFactory := traceFactory.(depstore.Factory) |
There was a problem hiding this comment.
@yurishkuro should we do a runtime cast or do we want to create a new constructor instead?
There was a problem hiding this comment.
hm, the bigger issue here is that if we want remote-storage to be fully v2 compatible there is not way to configure that, since you have to go through v1 CLI flags. We may need to make a breaking change and switch to yaml config similar to jaeger-v2
There was a problem hiding this comment.
One thing we perhaps could do is have a subcommand migrate which will support all the existing v1 flags (but won't enable them by default on the main command) and will use those flags to populate the config structs and write them out as YAML. But I am not sure this binary is actually used by anyone, so I would start with a breaking change and if people complain we could go this way with migrate subcommand.
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
mahadzaryab1
commented
Apr 15, 2025
| @@ -365,6 +377,7 @@ func TestServerGRPCTLS(t *testing.T) { | |||
| server, err := NewServer( | |||
| serverOptions, | |||
| f, | |||
| f, | |||
There was a problem hiding this comment.
a little awkward to have to pass the same factory in twice - should I break it out into two fake factories?
yurishkuro
approved these changes
Apr 15, 2025
amilbcahat
pushed a commit
to amilbcahat/jaeger
that referenced
this pull request
May 4, 2025
…rtracing#7024) <!-- !! Please DELETE this comment before posting. We appreciate your contribution to the Jaeger project! 👋🎉 --> ## Which problem is this PR solving? - Towards jaegertracing#6979 ## Description of the changes - Changes the remote storage server to accept v2 factories instead of v1 ## How was this change tested? - CI and unit tests ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` --------- Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
amilbcahat
pushed a commit
to amilbcahat/jaeger
that referenced
this pull request
May 4, 2025
…rtracing#7024) <!-- !! Please DELETE this comment before posting. We appreciate your contribution to the Jaeger project! 👋🎉 --> ## Which problem is this PR solving? - Towards jaegertracing#6979 ## Description of the changes - Changes the remote storage server to accept v2 factories instead of v1 ## How was this change tested? - CI and unit tests ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` --------- Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com> Signed-off-by: amol-verma-allen <amol.verma@allen.in>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test