Fix flakiness in runIndexCleanerTest by filtering Jaeger indices #7004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shubham Solanki <shubham24071999@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7004 +/- ##
==========================================
- Coverage 95.99% 95.96% -0.04%
==========================================
Files 346 346
Lines 20507 20552 +45
==========================================
+ Hits 19686 19722 +36
- Misses 618 626 +8
- Partials 203 204 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merged
via the queue into
jaegertracing:main
with commit Apr 10, 2025
ef87405
56 of 57 checks passed
|
Thanks! |
"You're welcome! Let me know if there are any other issues I can pick up." |
|
Anything with |
amilbcahat
pushed a commit
to amilbcahat/jaeger
that referenced
this pull request
May 4, 2025
…gertracing#7004) RESOLVE jaegertracing#7002 **issue:** - The test `runIndexCleanerTest` was flaky because it included unrelated system indices (e.g., `top_queries-2025.04.08-51429`). ## Description of the changes - Added `strings` import to use `strings.HasPrefix`. - Filtered indices to only include those starting with `prefixWithSeparator + "jaeger-"`. - Updated the assertion to use `filteredIndices` instead of raw `indices`. **Impact:** Ensures the test only checks relevant Jaeger indices, improving reliability. ## Checklist - [✓]I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [✓] I have signed all commits - [ ] I have added unit tests for the new functionality - [✓]I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` --------- Signed-off-by: Shubham Solanki <shubham24071999@gmail.com> Signed-off-by: Yuri Shkuro <github@ysh.us> Co-authored-by: Yuri Shkuro <github@ysh.us>
amilbcahat
pushed a commit
to amilbcahat/jaeger
that referenced
this pull request
May 4, 2025
…gertracing#7004) RESOLVE jaegertracing#7002 **issue:** - The test `runIndexCleanerTest` was flaky because it included unrelated system indices (e.g., `top_queries-2025.04.08-51429`). ## Description of the changes - Added `strings` import to use `strings.HasPrefix`. - Filtered indices to only include those starting with `prefixWithSeparator + "jaeger-"`. - Updated the assertion to use `filteredIndices` instead of raw `indices`. **Impact:** Ensures the test only checks relevant Jaeger indices, improving reliability. ## Checklist - [✓]I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [✓] I have signed all commits - [ ] I have added unit tests for the new functionality - [✓]I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` --------- Signed-off-by: Shubham Solanki <shubham24071999@gmail.com> Signed-off-by: Yuri Shkuro <github@ysh.us> Co-authored-by: Yuri Shkuro <github@ysh.us> Signed-off-by: amol-verma-allen <amol.verma@allen.in>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RESOLVE #7002
issue: - The test
runIndexCleanerTestwas flaky because it included unrelated system indices (e.g.,top_queries-2025.04.08-51429).Description of the changes
stringsimport to usestrings.HasPrefix.prefixWithSeparator + "jaeger-".filteredIndicesinstead of rawindices.Impact: Ensures the test only checks relevant Jaeger indices, improving reliability.
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test