Fix paths in mockery config #7045
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7045 +/- ##
==========================================
- Coverage 96.01% 95.99% -0.03%
==========================================
Files 349 349
Lines 20677 20677
==========================================
- Hits 19854 19849 -5
- Misses 620 624 +4
- Partials 203 204 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mahadzaryab1
approved these changes
Apr 18, 2025
3 tasks
amilbcahat
pushed a commit
to amilbcahat/jaeger
that referenced
this pull request
May 4, 2025
## Which problem is this PR solving? - When we did a recent move of a bunch of packages to internal/ the mocks were moved manually instead of being re-generated via mockery and the paths in the mockery config were not updated. The mockery run would log warnings, but unfortunately not fail. ## Description of the changes - Fix the paths to eliminate most warnings (the remaining one is deprecation notice) - Change Makefile target to first remove all mocks/*.go files to ensure generated code is not stale - Regenerate some affected mocks - Remove AgentService from crossdock (doesn't exist anymore) and fix the tests - We had a mock for `crossdock.T` stored and never regenerated. Moved it from under mocks/ into `t_mock_test.go`. ## How was this change tested? - CI --------- Signed-off-by: Yuri Shkuro <github@ysh.us>
amilbcahat
pushed a commit
to amilbcahat/jaeger
that referenced
this pull request
May 4, 2025
## Which problem is this PR solving? - When we did a recent move of a bunch of packages to internal/ the mocks were moved manually instead of being re-generated via mockery and the paths in the mockery config were not updated. The mockery run would log warnings, but unfortunately not fail. ## Description of the changes - Fix the paths to eliminate most warnings (the remaining one is deprecation notice) - Change Makefile target to first remove all mocks/*.go files to ensure generated code is not stale - Regenerate some affected mocks - Remove AgentService from crossdock (doesn't exist anymore) and fix the tests - We had a mock for `crossdock.T` stored and never regenerated. Moved it from under mocks/ into `t_mock_test.go`. ## How was this change tested? - CI --------- Signed-off-by: Yuri Shkuro <github@ysh.us> Signed-off-by: amol-verma-allen <amol.verma@allen.in>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
crossdock.Tstored and never regenerated. Moved it from under mocks/ intot_mock_test.go.How was this change tested?