Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.75%. Comparing base (40e1ff3) to head (0187c02).
Report is 6 commits behind head on main.

❌ Your project status has failed because the head coverage (50.75%) is below the target coverage (95.00%). You can increase the head coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (40e1ff3) and HEAD (0187c02). Click for more details.

HEAD has 23 uploads less than BASE

Flag	BASE (40e1ff3)	HEAD (0187c02)
badger_v1	2	1
grpc_v1	2	1
kafka-3.x-v1	2	1
badger_v2	2	1
memory_v2	2	1
grpc_v2	2	1
tailsampling-processor	2	1
elasticsearch-6.x-v1	2	1
kafka-3.x-v2	2	1
opensearch-1.x-v1	2	1
cassandra-4.x-v1-manual	2	1
cassandra-5.x-v1-manual	2	1
elasticsearch-8.x-v1	2	1
elasticsearch-7.x-v1	2	1
opensearch-2.x-v1	2	1
unittests	2	0
opensearch-2.x-v2	2	1
elasticsearch-8.x-v2	2	1
cassandra-5.x-v2-auto	2	1
cassandra-4.x-v2-manual	2	1
cassandra-4.x-v2-auto	2	1
cassandra-5.x-v2-manual	2	1

@@             Coverage Diff             @@
##             main    #7042       +/-   ##
===========================================
- Coverage   96.01%   50.75%   -45.27%     
===========================================
  Files         349      176      -173     
  Lines       20677    10701     -9976     
===========================================
- Hits        19854     5431    -14423     
- Misses        620     4868     +4248     
- Partials      203      402      +199     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro what failed in Lint Checks i did not quite get them.

it seems lots of test files are being generated for mocks now

?? cmd/collector/app/sanitizer/cache/mocks/mocks_test.go
?? cmd/ingester/app/consumer/mocks/mocks_test.go
?? cmd/ingester/app/processor/mocks/mocks_test.go

I am not sure what value these tests provide, as we don't test codegen files and exclude them from code coverage calculations. Can we tell mockery not to generate the test files?

it seems lots of test files are being generated for mocks now

?? cmd/collector/app/sanitizer/cache/mocks/mocks_test.go
?? cmd/ingester/app/consumer/mocks/mocks_test.go
?? cmd/ingester/app/processor/mocks/mocks_test.go

I am not sure what value these tests provide, as we don't test codegen files and exclude them from code coverage calculations. Can we tell mockery not to generate the test files?

I did not get any config option to disable the test files generation.

Turns out these are not test files, it's where mockery now generates the mocks. So your change builds fine in the CI because you did not delete any of the old files (which are used to compile code) and did not check-in the new files (which would not compile because they are used from other packages, and I don't think _test.go code is exposed outside of a package).

Turns out these are not test files, it's where mockery now generates the mocks. So your change builds fine in the CI because you did not delete any of the old files (which are used to compile code) and did not check-in the new files (which would not compile because they are used from other packages, and I don't think _test.go code is exposed outside of a package).

So old files are to be replaced with new mock files?

If there's no way to keep the old style files then you need to delete them and commit the new ones. I think it would also be good to do the deletion automatically by looping through all dirs in mockery config and running rm $dir/*.go before regenerating. This will ensure we don't have stale files.

I have removed all the old files but the issue is mocks_test.go being the only file in mocks folder golang ignores that module and does not import it so should i rename it to mocks.go

Change the file name to mocks.go, there is a config option guy for that.

Some of the generated mocks are failing unit tests. It is hard to pinpoint the reason. It seems there might be mismatch between mocks and actual function but i am not sure how to fix this.

I don't see any failures of tests in the CI

actually i tested them locally. Now i have pushed them to the pr

Something might have changed in mockery to make it more strict. We need to take this package by package. It's all fixable. Looking at some of the errors it seems obvious which arguments are missing to the mock calls.

See #7045 #7046

I think #7045 generates mocks in v2. .mockery.yaml had to be changed to v3 before generating mocks

https://vektra.github.io/mockery/latest/v3/

The issues you encounter are happening with mockery v2, so we need to fix them there first, to make the migration smoother. I think #7046 narrows down the issue to just Cassandra mocks

I think i encountered issues after migrating to v3. All the previous mocks are changed with new mocks.

I think if migrating to v3 was not the point then it defies the the purpose of the issue.

I think i encountered issues after migrating to v3.

Yes because the defaults were changed in v3 and we were already getting a warning about that in v2. So the better approach is to fix the warnings in v2 first before upgrading.

Oh! actually almost fixed all the warnings in v3 so now should I switch back to v2 fix the warnings by opening a new pr?

I removed the last instance of that flag (warning) #7048 (feel free to approve)

And you may have to recreate this PR after #7048 is merged, otherwise you will have lots of conflicts.

Closing this pr as it is already having lot of merge conflicts. Will open a new pr when #7048 is merged.