Move Cassandra Package from pkg/ to internal/ #6914
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sAchin-680 <mrmister680@gmail.com>
yurishkuro
requested changes
Mar 22, 2025
Signed-off-by: SACHIN KUMAR <118827645+sAchin-680@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your project status has failed because the head coverage (50.64%) is below the target coverage (95.00%). You can increase the head coverage or adjust the target coverage.
Additional details and impacted files@@ Coverage Diff @@
## main #6914 +/- ##
===========================================
- Coverage 96.24% 50.64% -45.60%
===========================================
Files 342 178 -164
Lines 20272 10463 -9809
===========================================
- Hits 19510 5299 -14211
- Misses 576 4769 +4193
- Partials 186 395 +209
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 2, 2025
## Which problem is this PR solving? - part of #6869 - closes #6914 (replacement) ## Description of the changes - moved `pkg/cassandra` to `internal/storage/cassandra` - users of `pkg/scassandra` are `internal/storage/v1/cassandra`, `internal/storage/distributedlock/cassandra`, `cmd/jaeger/internal/extension/jaegerstorage`. ## How was this change tested? - changes have passed all tests of the project ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` Signed-off-by: pipiland <nguyen.t.dang.minh@gmail.com>
amilbcahat
pushed a commit
to amilbcahat/jaeger
that referenced
this pull request
May 4, 2025
## Which problem is this PR solving? - part of jaegertracing#6869 - closes jaegertracing#6914 (replacement) ## Description of the changes - moved `pkg/cassandra` to `internal/storage/cassandra` - users of `pkg/scassandra` are `internal/storage/v1/cassandra`, `internal/storage/distributedlock/cassandra`, `cmd/jaeger/internal/extension/jaegerstorage`. ## How was this change tested? - changes have passed all tests of the project ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` Signed-off-by: pipiland <nguyen.t.dang.minh@gmail.com>
amilbcahat
pushed a commit
to amilbcahat/jaeger
that referenced
this pull request
May 4, 2025
## Which problem is this PR solving? - part of jaegertracing#6869 - closes jaegertracing#6914 (replacement) ## Description of the changes - moved `pkg/cassandra` to `internal/storage/cassandra` - users of `pkg/scassandra` are `internal/storage/v1/cassandra`, `internal/storage/distributedlock/cassandra`, `cmd/jaeger/internal/extension/jaegerstorage`. ## How was this change tested? - changes have passed all tests of the project ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` Signed-off-by: pipiland <nguyen.t.dang.minh@gmail.com> Signed-off-by: amol-verma-allen <amol.verma@allen.in>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
This PR moves the
cassandrapackage frompkg/tointernal/, aligning with Jaeger's internal package structure. The following subpackages and files have been moved:pkg/cassandra/config → internal/cassandra/configpkg/cassandra/gocql → internal/cassandra/gocqlpkg/cassandra/metrics → internal/cassandra/metricspkg/cassandra/mocks → internal/cassandra/mockspkg/cassandra/empty_test.go → internal/cassandra/empty_test.gopkg/cassandra/session.go → internal/cassandra/session.goHow was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test