Skip to content

Move pkg/prometheus to internal/config/promcfg #6911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 23, 2025
Merged

Move pkg/prometheus to internal/config/promcfg #6911

merged 5 commits into from
Mar 23, 2025

Conversation

danish9039
Copy link
Contributor

@danish9039 danish9039 commented Mar 22, 2025 •
edited by yurishkuro
Loading

Which problem is this PR solving?

Description of the changes

  • moved pkg/ prometheus to internal/prometheus

How was this change tested?

Checklist

@danish9039
Move pkg/prometheus to internal/prometheus
14416c6 
This change is part of our ongoing effort to move public packages that are not intended for external use into the /internal directory. This prevents accidental external dependencies on our implementation details.

- Moved all files from /pkg/prometheus to /internal/prometheus
- Updated all import paths throughout the codebase
- No functional changes

Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>
@danish9039
.
a9045ae 
Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>
@danish9039 danish9039 requested a review from a team as a code owner March 22, 2025 14:52
@danish9039 danish9039 requested a review from pavolloffay March 22, 2025 14:52
@codecov Codecov
Copy link

codecov bot commented Mar 22, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.13%. Comparing base (3d35eda) to head (f9db57e).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6911   +/-   ##
=======================================
  Coverage   96.13%   96.13%           
=======================================
  Files         340      340           
  Lines       19608    19608           
=======================================
  Hits        18851    18851           
  Misses        572      572           
  Partials      185      185
Flag Coverage Δ
badger_v1 10.21% <ø> (ø)
badger_v2 2.12% <ø> (ø)
cassandra-4.x-v1-manual 15.36% <ø> (ø)
cassandra-4.x-v2-auto 2.11% <ø> (ø)
cassandra-4.x-v2-manual 2.11% <ø> (ø)
cassandra-5.x-v1-manual 15.36% <ø> (ø)
cassandra-5.x-v2-auto 2.11% <ø> (ø)
cassandra-5.x-v2-manual 2.11% <ø> (ø)
elasticsearch-6.x-v1 20.12% <ø> (ø)
elasticsearch-7.x-v1 20.21% <ø> (ø)
elasticsearch-8.x-v1 20.38% <ø> (ø)
elasticsearch-8.x-v2 2.12% <ø> (ø)
grpc_v1 11.28% <ø> (ø)
grpc_v2 8.25% <ø> (ø)
kafka-3.x-v1 10.51% <ø> (ø)
kafka-3.x-v2 2.12% <ø> (ø)
memory_v2 2.12% <ø> (ø)
opensearch-1.x-v1 20.26% <ø> (ø)
opensearch-2.x-v1 20.26% <ø> (ø)
opensearch-2.x-v2 2.12% <ø> (ø)
tailsampling-processor 0.57% <ø> (ø)
unittests 94.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

yurishkuro
yurishkuro reviewed Mar 22, 2025
View reviewed changes
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this instead should be moved to internal/config/promcfg

@danish9039
moved to /internal/config/promcfg
82ac922 
Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>
@danish9039
removed
645e56d 
Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>
@danish9039 danish9039 changed the title moved pkg prometheus to internal/prometheus moved pkg/prometheus to internal/config/promcfg Mar 23, 2025
@danish9039
Merge branch 'main' into migrate-pkg-prometheus
f9db57e 
Signed-off-by: hippie-danish <133037056+danish9039@users.noreply.github.com>
@danish9039
Copy link
Contributor Author

this instead should be moved to internal/config/promcfg

done !

yurishkuro
yurishkuro approved these changes Mar 23, 2025
View reviewed changes
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@yurishkuro yurishkuro changed the title moved pkg/prometheus to internal/config/promcfg Move pkg/prometheus to internal/config/promcfg Mar 23, 2025
@yurishkuro yurishkuro added the changelog:refactoring Internal code refactoring without functional changes label Mar 23, 2025
@yurishkuro yurishkuro enabled auto-merge March 23, 2025 20:41
@yurishkuro yurishkuro added this pull request to the merge queue Mar 23, 2025
Merged via the queue into jaegertracing:main with commit 6174c01 Mar 23, 2025
56 of 57 checks passed
amilbcahat pushed a commit to amilbcahat/jaeger that referenced this pull request May 4, 2025
@danish9039 @amol-verma-allen
Move pkg/prometheus to internal/config/promcfg (jaegertracing#6911)
41ff2a8 
## Which problem is this PR solving?
- part of jaegertracing#6869

## Description of the changes
- moved `pkg/ prometheus` to` internal/prometheus`

## How was this change tested?
- 

## Checklist
- [ ] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [ ] I have signed all commits
- [ ] I have added unit tests for the new functionality
- [ ] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `npm run lint` and `npm run test`

---------

Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>
Signed-off-by: hippie-danish <133037056+danish9039@users.noreply.github.com>
amilbcahat pushed a commit to amilbcahat/jaeger that referenced this pull request May 4, 2025
@danish9039 @amol-verma-allen
Move pkg/prometheus to internal/config/promcfg (jaegertracing#6911)
5f7ad47 
## Which problem is this PR solving?
- part of jaegertracing#6869

## Description of the changes
- moved `pkg/ prometheus` to` internal/prometheus`

## How was this change tested?
-

## Checklist
- [ ] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [ ] I have signed all commits
- [ ] I have added unit tests for the new functionality
- [ ] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `npm run lint` and `npm run test`

---------

Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>
Signed-off-by: hippie-danish <133037056+danish9039@users.noreply.github.com>
Signed-off-by: amol-verma-allen <amol.verma@allen.in>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurishkuro yurishkuro yurishkuro approved these changes

@pavolloffay pavolloffay Awaiting requested review from pavolloffay pavolloffay is a code owner automatically assigned from jaegertracing/jaeger-maintainers

Assignees
No one assigned
Labels
changelog:refactoring Internal code refactoring without functional changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danish9039 @yurishkuro