Migrate pkg/otelsemconv to internal/otelsemconv #6910
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is part of our ongoing effort to move public packages that are not intended for external use into the /internal directory. This prevents accidental external dependencies on our implementation details. - Moved all files from /pkg/otelsemconv to /internal/otelsemconv - Updated all import paths throughout the codebase - No functional changes Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6910 +/- ##
==========================================
- Coverage 96.17% 96.15% -0.02%
==========================================
Files 341 341
Lines 19738 19738
==========================================
- Hits 18983 18980 -3
- Misses 571 573 +2
- Partials 184 185 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yurishkuro
requested changes
Mar 22, 2025
There was a problem hiding this comment.
I would rather move this under internal/telemetry/otelsemconv, once #6912 is merged
4 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 2, 2025
## Which problem is this PR solving? - part of #6869 - closes #6910 (replacement) ## Description of the changes - Move `pkg/otelsemconv` to `internal/telemetry/otelsemconv` ## How was this change tested? - changes have passed all tests of the project ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` Signed-off-by: pipiland <nguyen.t.dang.minh@gmail.com>
amilbcahat
pushed a commit
to amilbcahat/jaeger
that referenced
this pull request
May 4, 2025
…#6961) ## Which problem is this PR solving? - part of jaegertracing#6869 - closes jaegertracing#6910 (replacement) ## Description of the changes - Move `pkg/otelsemconv` to `internal/telemetry/otelsemconv` ## How was this change tested? - changes have passed all tests of the project ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` Signed-off-by: pipiland <nguyen.t.dang.minh@gmail.com>
amilbcahat
pushed a commit
to amilbcahat/jaeger
that referenced
this pull request
May 4, 2025
…#6961) ## Which problem is this PR solving? - part of jaegertracing#6869 - closes jaegertracing#6910 (replacement) ## Description of the changes - Move `pkg/otelsemconv` to `internal/telemetry/otelsemconv` ## How was this change tested? - changes have passed all tests of the project ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` Signed-off-by: pipiland <nguyen.t.dang.minh@gmail.com> Signed-off-by: amol-verma-allen <amol.verma@allen.in>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
pkg/otelsemconvtointernal/otelsemconvHow was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test