export model and protocol type #691
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
May I know the use case for this? Are you planning on writing an entirely new span model? |
|
@black-adder We want merge jaeger agent into our agent, so that we can manage only one agent on all servers. |
|
@black-adder Can this be merged？ |
|
Sure, some tests are failing though: cmd/agent/app/builder_test.go:159:15: undefined: model |
|
Thank you, I will fix it tomorrow morning |
The `ProcessorConfiguration` can be exported, but the custom type `model` and `protocol` can not, so it's hard to new a `ProcessorConfiguration` outside the pacaage. Signed-off-by: kun <oiooj@qq.com>
|
@black-adder updated |
black-adder
approved these changes
Feb 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ProcessorConfigurationcan be exported, but the custom typemodelandprotocolcan not, so it's hard to new aProcessorConfigurationoutside the package.Signed-off-by: kun oiooj@qq.com