Skip to content

[grpc][v2] Implement FindTraces in gRPC v2 handler #6992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Apr 8, 2025
Merged

[grpc][v2] Implement FindTraces in gRPC v2 handler #6992

merged 14 commits into from
Apr 8, 2025

Conversation

mahadzaryab1
Copy link
Collaborator

@mahadzaryab1 mahadzaryab1 commented Apr 6, 2025 •
edited
Loading

Which problem is this PR solving?

Description of the changes

  • Implement the FindTraces call in the gRPC v2 handler

How was this change tested?

  • Added unit tests

Checklist

@mahadzaryab1
Add Helper To Convert Key Value List To Map
b5e634f 
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
@mahadzaryab1
Add Unit Tests
e40b4ce 
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
@mahadzaryab1
Add Edge Case Tests
9616aea 
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
@mahadzaryab1
Add Implementation For Find Traces
712a7a7 
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
@mahadzaryab1 mahadzaryab1 added the changelog:exprimental Change to an experimental part of the code label Apr 6, 2025
@mahadzaryab1
Simplify
91690f1 
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
@mahadzaryab1
Change Test Server Embedding
3a5428c 
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
@codecov Codecov
Copy link

codecov bot commented Apr 6, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.99%. Comparing base (06840ac) to head (029b034).
Report is 8 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6992   +/-   ##
=======================================
  Coverage   95.99%   95.99%           
=======================================
  Files         346      346           
  Lines       20429    20507   +78     
=======================================
+ Hits        19611    19686   +75     
- Misses        616      618    +2     
- Partials      202      203    +1
Flag Coverage Δ
badger_v1 10.53% <ø> (ø)
badger_v2 2.18% <ø> (ø)
cassandra-4.x-v1-manual 15.84% <ø> (ø)
cassandra-4.x-v2-auto 2.17% <ø> (ø)
cassandra-4.x-v2-manual 2.17% <ø> (ø)
cassandra-5.x-v1-manual 15.84% <ø> (ø)
cassandra-5.x-v2-auto 2.17% <ø> (ø)
cassandra-5.x-v2-manual 2.17% <ø> (ø)
elasticsearch-6.x-v1 20.76% <ø> (ø)
elasticsearch-7.x-v1 20.84% <ø> (ø)
elasticsearch-8.x-v1 21.02% <ø> (ø)
elasticsearch-8.x-v2 2.18% <ø> (ø)
grpc_v1 11.61% <ø> (ø)
grpc_v2 8.47% <ø> (ø)
kafka-3.x-v1 10.82% <ø> (ø)
kafka-3.x-v2 2.18% <ø> (ø)
memory_v2 2.18% <ø> (ø)
opensearch-1.x-v1 20.89% <ø> (ø)
opensearch-2.x-v1 20.89% <ø> (ø)
opensearch-2.x-v2 2.18% <ø> (ø)
tailsampling-processor 0.59% <ø> (ø)
unittests 94.79% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mahadzaryab1
Add Unit Tests
c96840a 
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
@mahadzaryab1
Add Some Missing Code Coverage Paths
e0a7513 
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
@mahadzaryab1
Cover More Code Paths
a3f3515 
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
@mahadzaryab1
Cover More Code Paths
df1e5e1 
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
@mahadzaryab1 mahadzaryab1 changed the title [WIP][grpc][v2] Implement FindTraces in gRPC v2 handler [grpc][v2] Implement FindTraces in gRPC v2 handler Apr 8, 2025
@mahadzaryab1 mahadzaryab1 marked this pull request as ready for review April 8, 2025 01:41
@mahadzaryab1 mahadzaryab1 requested a review from a team as a code owner April 8, 2025 01:41
@mahadzaryab1 mahadzaryab1 requested a review from jkowall April 8, 2025 01:41
@mahadzaryab1 mahadzaryab1 requested a review from yurishkuro April 8, 2025 01:41
@mahadzaryab1
Add Missing Code Coverage
c64cd66 
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
@mahadzaryab1
Fix
e4b452d 
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
@mahadzaryab1
Add Missing Code Coverage
147b5dd 
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
@mahadzaryab1
Add Missing Code Coverage
029b034 
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
@mahadzaryab1 mahadzaryab1 added this pull request to the merge queue Apr 8, 2025
Merged via the queue into jaegertracing:main with commit d12f1f9 Apr 8, 2025
56 checks passed
@mahadzaryab1 mahadzaryab1 deleted the grpc-server-find-traces branch April 9, 2025 00:31
amilbcahat pushed a commit to amilbcahat/jaeger that referenced this pull request May 4, 2025
@mahadzaryab1 @amol-verma-allen
[grpc][v2] Implement FindTraces in gRPC v2 handler (jaegertracing#6992
8c69bbb 
)

## Which problem is this PR solving?
- Towards jaegertracing#6979

## Description of the changes
- Implement the `FindTraces` call in the gRPC v2 handler

## How was this change tested?
- Added unit tests

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [x] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `npm run lint` and `npm run test`

---------

Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
amilbcahat pushed a commit to amilbcahat/jaeger that referenced this pull request May 4, 2025
@mahadzaryab1 @amol-verma-allen
[grpc][v2] Implement FindTraces in gRPC v2 handler (jaegertracing#6992
fe34670 
)

## Which problem is this PR solving?
- Towards jaegertracing#6979

## Description of the changes
- Implement the `FindTraces` call in the gRPC v2 handler

## How was this change tested?
- Added unit tests

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [x] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `npm run lint` and `npm run test`

---------

Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: amol-verma-allen <amol.verma@allen.in>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurishkuro yurishkuro yurishkuro approved these changes

@jkowall jkowall Awaiting requested review from jkowall jkowall is a code owner automatically assigned from jaegertracing/jaeger-maintainers

Assignees
No one assigned
Labels
area/storage changelog:exprimental Change to an experimental part of the code v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mahadzaryab1 @yurishkuro