Skip to content

[grpc][v2] Implement gRPC v2 factory #6968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Apr 2, 2025
Merged

[grpc][v2] Implement gRPC v2 factory #6968

merged 14 commits into from
Apr 2, 2025

Conversation

mahadzaryab1
Copy link
Collaborator

@mahadzaryab1 mahadzaryab1 commented Apr 2, 2025 •
edited
Loading

Which problem is this PR solving?

Description of the changes

  • This PR implements the following factories for gRPC storage
    • io.Closer
    • tracestore.Factory
    • depstore.Factory

How was this change tested?

  • Added unit tests

Checklist

@mahadzaryab1
Add Configuration For v2 gRPC Factory
a5836d3 
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
@mahadzaryab1
Add Initial Functions For Factory
cc47ea5 
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
@mahadzaryab1
Implement io.Closer
08fb741 
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
@mahadzaryab1
Implement Factories
eee7199 
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
@mahadzaryab1 mahadzaryab1 added the changelog:exprimental Change to an experimental part of the code label Apr 2, 2025
yurishkuro
yurishkuro reviewed Apr 2, 2025
View reviewed changes
@mahadzaryab1
Add Unit Test For config.go
e9066f2 
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
@mahadzaryab1
Address Feedback
74bfa49 
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
@codecov Codecov
Copy link

codecov bot commented Apr 2, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 96.15385% with 3 lines in your changes missing coverage. Please review.

Project coverage is 96.24%. Comparing base (13cb216) to head (274def7).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
internal/storage/v2/grpc/factory.go 95.83% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6968      +/-   ##
==========================================
+ Coverage   96.21%   96.24%   +0.02%     
==========================================
  Files         343      345       +2     
  Lines       20281    20359      +78     
==========================================
+ Hits        19513    19594      +81     
+ Misses        579      577       -2     
+ Partials      189      188       -1
Flag Coverage Δ
badger_v1 10.53% <ø> (ø)
badger_v2 2.18% <ø> (ø)
cassandra-4.x-v1-manual 15.84% <ø> (ø)
cassandra-4.x-v2-auto 2.17% <ø> (ø)
cassandra-4.x-v2-manual 2.17% <ø> (ø)
cassandra-5.x-v1-manual 15.84% <ø> (ø)
cassandra-5.x-v2-auto 2.17% <ø> (ø)
cassandra-5.x-v2-manual 2.17% <ø> (ø)
elasticsearch-6.x-v1 20.76% <ø> (ø)
elasticsearch-7.x-v1 20.84% <ø> (ø)
elasticsearch-8.x-v1 21.02% <ø> (ø)
elasticsearch-8.x-v2 2.18% <ø> (ø)
grpc_v1 11.61% <ø> (ø)
grpc_v2 8.47% <ø> (ø)
kafka-3.x-v1 10.82% <ø> (ø)
kafka-3.x-v2 2.18% <ø> (ø)
memory_v2 2.18% <ø> (ø)
opensearch-1.x-v1 20.89% <ø> (ø)
opensearch-2.x-v1 20.89% <ø> (ø)
opensearch-2.x-v2 2.18% <ø> (ø)
tailsampling-processor 0.59% <ø> (ø)
unittests 95.03% <96.15%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mahadzaryab1
Return Initialization Error
0f4e0b0 
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
@mahadzaryab1
Add Test For NewFactory
daeef3a 
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
@mahadzaryab1
Use Cleanup
ceed932 
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
@mahadzaryab1
Add Tests For Factory Usage
8da4a37 
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
@mahadzaryab1
Use Helper
a420f2e 
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
@mahadzaryab1
Add Missing Code Path
a995050 
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
@mahadzaryab1
Add Documentation
f706518 
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
@mahadzaryab1 mahadzaryab1 changed the title [WIP][grpc][v2] Implement gRPC v2 factory [grpc][v2] Implement gRPC v2 factory Apr 2, 2025
@mahadzaryab1 mahadzaryab1 marked this pull request as ready for review April 2, 2025 20:57
@mahadzaryab1 mahadzaryab1 requested a review from a team as a code owner April 2, 2025 20:57
@mahadzaryab1 mahadzaryab1 requested a review from albertteoh April 2, 2025 20:57
@mahadzaryab1 mahadzaryab1 requested a review from yurishkuro April 2, 2025 20:57
yurishkuro
yurishkuro reviewed Apr 2, 2025
View reviewed changes
@mahadzaryab1
Remove Telset Assignment
274def7 
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
@mahadzaryab1 mahadzaryab1 enabled auto-merge April 2, 2025 21:17
@mahadzaryab1 mahadzaryab1 added this pull request to the merge queue Apr 2, 2025
Merged via the queue into jaegertracing:main with commit dddd44c Apr 2, 2025
56 checks passed
@mahadzaryab1 mahadzaryab1 deleted the grpc-v2-factory branch April 3, 2025 00:18
amilbcahat pushed a commit to amilbcahat/jaeger that referenced this pull request May 4, 2025
@mahadzaryab1 @amol-verma-allen
[grpc][v2] Implement gRPC v2 factory (jaegertracing#6968)
7322c3e 
<!--
!! Please DELETE this comment before posting.
We appreciate your contribution to the Jaeger project! 👋🎉
-->

## Which problem is this PR solving?
- Towards jaegertracing#6965

## Description of the changes
- This PR implements the following factories for gRPC storage
  - `io.Closer`
  - `tracestore.Factory`
  - `depstore.Factory`
## How was this change tested?
- Added unit tests

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [x] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `npm run lint` and `npm run test`

---------

Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
amilbcahat pushed a commit to amilbcahat/jaeger that referenced this pull request May 4, 2025
@mahadzaryab1 @amol-verma-allen
[grpc][v2] Implement gRPC v2 factory (jaegertracing#6968)
90029d1 
<!--
!! Please DELETE this comment before posting.
We appreciate your contribution to the Jaeger project! 👋🎉
-->

## Which problem is this PR solving?
- Towards jaegertracing#6965

## Description of the changes
- This PR implements the following factories for gRPC storage
  - `io.Closer`
  - `tracestore.Factory`
  - `depstore.Factory`
## How was this change tested?
- Added unit tests

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [x] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `npm run lint` and `npm run test`

---------

Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: amol-verma-allen <amol.verma@allen.in>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurishkuro yurishkuro yurishkuro approved these changes

@albertteoh albertteoh Awaiting requested review from albertteoh albertteoh is a code owner automatically assigned from jaegertracing/jaeger-maintainers

Assignees
No one assigned
Labels
area/storage changelog:exprimental Change to an experimental part of the code v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mahadzaryab1 @yurishkuro