Move proto-gen to internal #6941
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6941 +/- ##
==========================================
- Coverage 96.26% 96.22% -0.05%
==========================================
Files 343 344 +1
Lines 20313 20255 -58
==========================================
- Hits 19554 19490 -64
- Misses 574 577 +3
- Partials 185 188 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mahadzaryab1
approved these changes
Mar 29, 2025
amilbcahat
pushed a commit
to amilbcahat/jaeger
that referenced
this pull request
May 4, 2025
## Which problem is this PR solving? - Part of jaegertracing#6869 ## Description of the changes - Move `proto-gen/*` under `internal/` ## How was this change tested? - CI --------- Signed-off-by: Yuri Shkuro <github@ysh.us>
amilbcahat
pushed a commit
to amilbcahat/jaeger
that referenced
this pull request
May 4, 2025
## Which problem is this PR solving? - Part of jaegertracing#6869 ## Description of the changes - Move `proto-gen/*` under `internal/` ## How was this change tested? - CI --------- Signed-off-by: Yuri Shkuro <github@ysh.us> Signed-off-by: amol-verma-allen <amol.verma@allen.in>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
proto-gen/*underinternal/How was this change tested?