Skip to content

Move pkg/fswatcher to internal/fswatcher #6895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 22, 2025
Merged

Move pkg/fswatcher to internal/fswatcher #6895

merged 3 commits into from
Mar 22, 2025

Conversation

sAchin-680
Copy link
Contributor

@sAchin-680 sAchin-680 commented Mar 22, 2025 •
edited
Loading

Which problem is this PR solving?

Description of the changes

  • Moved pkg/fswatcher to internal/fswatcher
  • Updated all imports referencing pkg/fswatcher to internal/fswatcher

How was this change tested?

  • Verified that the code compiles successfully: 
    make build
  • Ran tests for fswatcher to ensure functionality remains intact:
   go test -v ./internal/fswatcher/...
  • Ran all tests to confirm that no other parts of the project were affected: 
       make test

Checklist

@sAchin-680
Move fswatcher to internal/
6c6ab8b 
Signed-off-by: sAchin-680 <mrmister680@gmail.com>
@sAchin-680 sAchin-680 requested a review from a team as a code owner March 22, 2025 08:55
@sAchin-680 sAchin-680 requested a review from jkowall March 22, 2025 08:55
@codecov Codecov
Copy link

codecov bot commented Mar 22, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.15%. Comparing base (d3f6682) to head (3843d16).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6895      +/-   ##
==========================================
- Coverage   96.17%   96.15%   -0.02%     
==========================================
  Files         341      341              
  Lines       19738    19738              
==========================================
- Hits        18983    18980       -3     
- Misses        571      573       +2     
- Partials      184      185       +1
Flag Coverage Δ
badger_v1 10.20% <ø> (ø)
badger_v2 2.12% <ø> (ø)
cassandra-4.x-v1-manual 15.36% <ø> (ø)
cassandra-4.x-v2-auto 2.11% <ø> (ø)
cassandra-4.x-v2-manual 2.11% <ø> (ø)
cassandra-5.x-v1-manual 15.36% <ø> (ø)
cassandra-5.x-v2-auto 2.11% <ø> (ø)
cassandra-5.x-v2-manual 2.11% <ø> (ø)
elasticsearch-6.x-v1 20.15% <ø> (ø)
elasticsearch-7.x-v1 20.23% <ø> (ø)
elasticsearch-8.x-v1 20.40% <ø> (ø)
elasticsearch-8.x-v2 2.12% <ø> (ø)
grpc_v1 11.28% <ø> (ø)
grpc_v2 8.25% <ø> (ø)
kafka-3.x-v1 10.51% <ø> (ø)
kafka-3.x-v2 2.12% <ø> (ø)
memory_v2 2.12% <ø> (ø)
opensearch-1.x-v1 20.28% <ø> (ø)
opensearch-2.x-v1 20.28% <ø> (ø)
opensearch-2.x-v2 2.12% <ø> (ø)
tailsampling-processor 0.57% <ø> (ø)
unittests 94.94% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yurishkuro yurishkuro added the changelog:refactoring Internal code refactoring without functional changes label Mar 22, 2025
yurishkuro and others added 2 commits March 22, 2025 13:21
@yurishkuro
make fmt
19d0e0d 
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro
Merge branch 'main' into move-fswatcher-to-internal
3843d16
@yurishkuro yurishkuro enabled auto-merge March 22, 2025 17:22
@yurishkuro yurishkuro added this pull request to the merge queue Mar 22, 2025
auto-merge was automatically disabled March 22, 2025 17:38

Pull Request is not mergeable

Merged via the queue into jaegertracing:main with commit c1c6845 Mar 22, 2025
56 checks passed
Manik2708 pushed a commit to Manik2708/jaeger that referenced this pull request Mar 23, 2025
@sAchin-680 @yurishkuro @Manik2708
Move pkg/fswatcher to internal/fswatcher (jaegertracing#6895)
10b10f7 
## Which problem is this PR solving?
- Moves `pkg/fswatcher` to `internal/fswatcher` as part of issue jaegertracing#6869 

## Description of the changes
- Moved `pkg/fswatcher` to `internal/fswatcher`  
- Updated all imports referencing `pkg/fswatcher` to
`internal/fswatcher`

## How was this change tested?
- Verified that the code compiles successfully:  
  ```bash
  make build
   ```
 - Ran tests for fswatcher to ensure functionality remains intact:
  ```bash
     go test -v ./internal/fswatcher/...
  ```
- Ran all tests to confirm that no other parts of the project were
affected:
  ```bash
     make test
  ```

## Checklist
- [ ] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [ ] I have signed all commits
- [ ] I have added unit tests for the new functionality
- [ ] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `npm run lint` and `npm run test`

---------

Signed-off-by: sAchin-680 <mrmister680@gmail.com>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Co-authored-by: Yuri Shkuro <github@ysh.us>
Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
amilbcahat pushed a commit to amilbcahat/jaeger that referenced this pull request May 4, 2025
@sAchin-680 @yurishkuro @amol-verma-allen
Move pkg/fswatcher to internal/fswatcher (jaegertracing#6895)
383ca22 
## Which problem is this PR solving?
- Moves `pkg/fswatcher` to `internal/fswatcher` as part of issue jaegertracing#6869 

## Description of the changes
- Moved `pkg/fswatcher` to `internal/fswatcher`  
- Updated all imports referencing `pkg/fswatcher` to
`internal/fswatcher`

## How was this change tested?
- Verified that the code compiles successfully:  
  ```bash
  make build
   ```
 - Ran tests for fswatcher to ensure functionality remains intact:
  ```bash
     go test -v ./internal/fswatcher/...
  ```
- Ran all tests to confirm that no other parts of the project were
affected:
  ```bash
     make test
  ```

## Checklist
- [ ] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [ ] I have signed all commits
- [ ] I have added unit tests for the new functionality
- [ ] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `npm run lint` and `npm run test`

---------

Signed-off-by: sAchin-680 <mrmister680@gmail.com>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Co-authored-by: Yuri Shkuro <github@ysh.us>
Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
amilbcahat pushed a commit to amilbcahat/jaeger that referenced this pull request May 4, 2025
@sAchin-680 @yurishkuro @amol-verma-allen
Move pkg/fswatcher to internal/fswatcher (jaegertracing#6895)
93931be 
## Which problem is this PR solving?
- Moves `pkg/fswatcher` to `internal/fswatcher` as part of issue jaegertracing#6869

## Description of the changes
- Moved `pkg/fswatcher` to `internal/fswatcher`
- Updated all imports referencing `pkg/fswatcher` to
`internal/fswatcher`

## How was this change tested?
- Verified that the code compiles successfully:
  ```bash
  make build
   ```
 - Ran tests for fswatcher to ensure functionality remains intact:
  ```bash
     go test -v ./internal/fswatcher/...
  ```
- Ran all tests to confirm that no other parts of the project were
affected:
  ```bash
     make test
  ```

## Checklist
- [ ] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [ ] I have signed all commits
- [ ] I have added unit tests for the new functionality
- [ ] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `npm run lint` and `npm run test`

---------

Signed-off-by: sAchin-680 <mrmister680@gmail.com>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Co-authored-by: Yuri Shkuro <github@ysh.us>
Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
Signed-off-by: amol-verma-allen <amol.verma@allen.in>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurishkuro yurishkuro yurishkuro approved these changes

@jkowall jkowall Awaiting requested review from jkowall jkowall is a code owner automatically assigned from jaegertracing/jaeger-maintainers

Assignees
No one assigned
Labels
changelog:refactoring Internal code refactoring without functional changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sAchin-680 @yurishkuro