Skip to content

[ES] Remove pointer signatures from CoreSpanReader #6874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 19, 2025
Merged

[ES] Remove pointer signatures from CoreSpanReader #6874

merged 4 commits into from
Mar 19, 2025

Conversation

Manik2708
Copy link
Contributor

Which problem is this PR solving?

Fixes a part of: #6458

Description of the changes

  • Removal of pointer signatures from CoreSpanReader

How was this change tested?

  • Unit Tests

Checklist

@Manik2708
[ES] Remove pointer signatures from CoreSpanReader
727b5db 
Signed-off-by: Manik2708 <mehtamanik96@gmail.com>
@Manik2708 Manik2708 requested a review from a team as a code owner March 19, 2025 00:10
@Manik2708 Manik2708 requested a review from jkowall March 19, 2025 00:10
@codecov Codecov
Copy link

codecov bot commented Mar 19, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.17%. Comparing base (64a6aef) to head (e6af530).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6874      +/-   ##
==========================================
- Coverage   96.21%   96.17%   -0.04%     
==========================================
  Files         344      344              
  Lines       19976    19972       -4     
==========================================
- Hits        19219    19209      -10     
- Misses        573      577       +4     
- Partials      184      186       +2
Flag Coverage Δ
badger_v1 9.87% <0.00%> (+<0.01%) ⬆️
badger_v2 2.05% <0.00%> (+<0.01%) ⬆️
cassandra-4.x-v1-manual 14.85% <0.00%> (+<0.01%) ⬆️
cassandra-4.x-v2-auto 2.04% <0.00%> (+<0.01%) ⬆️
cassandra-4.x-v2-manual 2.04% <0.00%> (+<0.01%) ⬆️
cassandra-5.x-v1-manual 14.85% <0.00%> (+<0.01%) ⬆️
cassandra-5.x-v2-auto 2.04% <0.00%> (+<0.01%) ⬆️
cassandra-5.x-v2-manual 2.04% <0.00%> (+<0.01%) ⬆️
elasticsearch-6.x-v1 19.49% <95.45%> (-0.01%) ⬇️
elasticsearch-7.x-v1 19.57% <95.45%> (-0.01%) ⬇️
elasticsearch-8.x-v1 19.74% <95.45%> (-0.01%) ⬇️
elasticsearch-8.x-v2 2.05% <0.00%> (+<0.01%) ⬆️
grpc_v1 10.91% <0.00%> (+<0.01%) ⬆️
grpc_v2 7.97% <0.00%> (+<0.01%) ⬆️
kafka-3.x-v1 10.17% <0.00%> (+<0.01%) ⬆️
kafka-3.x-v2 2.05% <0.00%> (+<0.01%) ⬆️
memory_v2 2.05% <0.00%> (+<0.01%) ⬆️
opensearch-1.x-v1 19.62% <95.45%> (-0.01%) ⬇️
opensearch-2.x-v1 19.62% <95.45%> (-0.01%) ⬇️
opensearch-2.x-v2 2.05% <0.00%> (+<0.01%) ⬆️
tailsampling-processor 0.55% <0.00%> (+<0.01%) ⬆️
unittests 94.98% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

yurishkuro
yurishkuro reviewed Mar 19, 2025
View reviewed changes
@Manik2708
cleanup
835a665 
Signed-off-by: Manik2708 <mehtamanik96@gmail.com>
@Manik2708 Manik2708 requested a review from yurishkuro March 19, 2025 00:26
yurishkuro
yurishkuro reviewed Mar 19, 2025
View reviewed changes
yurishkuro
yurishkuro reviewed Mar 19, 2025
View reviewed changes
yurishkuro
yurishkuro reviewed Mar 19, 2025
View reviewed changes
yurishkuro
yurishkuro reviewed Mar 19, 2025
View reviewed changes
yurishkuro
yurishkuro reviewed Mar 19, 2025
View reviewed changes
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of improvements, otherwise lgtm, thanks for following up

@yurishkuro yurishkuro added the changelog:refactoring Internal code refactoring without functional changes label Mar 19, 2025
@Manik2708
cleanup
e6af530 
Signed-off-by: Manik2708 <mehtamanik96@gmail.com>
@Manik2708 Manik2708 requested a review from yurishkuro March 19, 2025 00:51
@yurishkuro yurishkuro enabled auto-merge March 19, 2025 00:56
@yurishkuro yurishkuro added this pull request to the merge queue Mar 19, 2025
Merged via the queue into jaegertracing:main with commit 4e58aea Mar 19, 2025
56 checks passed
@Manik2708 Manik2708 deleted the pointer branch March 19, 2025 09:07
sAchin-680 pushed a commit to sAchin-680/jaeger that referenced this pull request Mar 19, 2025
@Manik2708 @sAchin-680
[ES] Remove pointer signatures from CoreSpanReader (jaegertracing#6874
f00df84 
)

## Which problem is this PR solving?
Fixes a part of: jaegertracing#6458

## Description of the changes
- Removal of pointer signatures from `CoreSpanReader`

## How was this change tested?
- Unit Tests

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [x] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `npm run lint` and `npm run test`

---------

Signed-off-by: Manik2708 <mehtamanik96@gmail.com>
Signed-off-by: sAchin-680 <mrmister680@gmail.com>
amilbcahat pushed a commit to amilbcahat/jaeger that referenced this pull request May 4, 2025
@Manik2708 @amol-verma-allen
[ES] Remove pointer signatures from CoreSpanReader (jaegertracing#6874
23b06d6 
)

## Which problem is this PR solving?
Fixes a part of: jaegertracing#6458 

## Description of the changes
- Removal of pointer signatures from `CoreSpanReader`

## How was this change tested?
- Unit Tests

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [x] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `npm run lint` and `npm run test`

---------

Signed-off-by: Manik2708 <mehtamanik96@gmail.com>
amilbcahat pushed a commit to amilbcahat/jaeger that referenced this pull request May 4, 2025
@Manik2708 @amol-verma-allen
[ES] Remove pointer signatures from CoreSpanReader (jaegertracing#6874
dcd70df 
)

## Which problem is this PR solving?
Fixes a part of: jaegertracing#6458

## Description of the changes
- Removal of pointer signatures from `CoreSpanReader`

## How was this change tested?
- Unit Tests

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [x] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `npm run lint` and `npm run test`

---------

Signed-off-by: Manik2708 <mehtamanik96@gmail.com>
Signed-off-by: amol-verma-allen <amol.verma@allen.in>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurishkuro yurishkuro yurishkuro approved these changes

@jkowall jkowall Awaiting requested review from jkowall jkowall is a code owner automatically assigned from jaegertracing/jaeger-maintainers

Assignees
No one assigned
Labels
changelog:refactoring Internal code refactoring without functional changes storage/elasticsearch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Manik2708 @yurishkuro