[refactor] Move interface to remove cmd/agent dependency #6863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Shkuro <github@ysh.us>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6863 +/- ##
=======================================
Coverage 96.07% 96.07%
=======================================
Files 367 367
Lines 20831 20831
=======================================
Hits 20013 20013
Misses 624 624
Partials 194 194
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merged
via the queue into
jaegertracing:main
with commit Mar 18, 2025
2be68dc
56 of 57 checks passed
sAchin-680
pushed a commit
to sAchin-680/jaeger
that referenced
this pull request
Mar 19, 2025
…ng#6863) ## Which problem is this PR solving? - Towards jaegertracing#4739 - This was the only dependency on cmd/agent from other packages. Once the next release of OTEL Contrib lands we can remove cmd/agent. ## Description of the changes - Copy the interface into internal/sampling/http/handler.go ## How was this change tested? - CI Signed-off-by: Yuri Shkuro <github@ysh.us> Signed-off-by: sAchin-680 <mrmister680@gmail.com>
amilbcahat
pushed a commit
to amilbcahat/jaeger
that referenced
this pull request
May 4, 2025
…ng#6863) ## Which problem is this PR solving? - Towards jaegertracing#4739 - This was the only dependency on cmd/agent from other packages. Once the next release of OTEL Contrib lands we can remove cmd/agent. ## Description of the changes - Copy the interface into internal/sampling/http/handler.go ## How was this change tested? - CI Signed-off-by: Yuri Shkuro <github@ysh.us>
amilbcahat
pushed a commit
to amilbcahat/jaeger
that referenced
this pull request
May 4, 2025
…ng#6863) ## Which problem is this PR solving? - Towards jaegertracing#4739 - This was the only dependency on cmd/agent from other packages. Once the next release of OTEL Contrib lands we can remove cmd/agent. ## Description of the changes - Copy the interface into internal/sampling/http/handler.go ## How was this change tested? - CI Signed-off-by: Yuri Shkuro <github@ysh.us> Signed-off-by: amol-verma-allen <amol.verma@allen.in>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
How was this change tested?