Skip to content

[test]: Check for jaeger-idl version mismatch #6753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 19, 2025
Merged

[test]: Check for jaeger-idl version mismatch #6753

merged 6 commits into from
Feb 19, 2025

Conversation

ary82
Copy link
Contributor

@ary82 ary82 commented Feb 18, 2025

Which problem is this PR solving?

Description of the changes

  • Create a bash script for getting semantic versions of go.mod dependency and git submodule
  • Update CI

How was this change tested?

Checklist

@ary82
[test]: Check for jaeger-idl version mismatch
9de2bdc 
Signed-off-by: Aryan Goyal <137564277+ary82@users.noreply.github.com>
@ary82 ary82 requested a review from a team as a code owner February 18, 2025 23:43
@ary82 ary82 requested a review from joe-elliott February 18, 2025 23:43
@codecov Codecov
Copy link

codecov bot commented Feb 18, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.04%. Comparing base (11cfbce) to head (4a34a43).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6753      +/-   ##
==========================================
- Coverage   96.06%   96.04%   -0.02%     
==========================================
  Files         364      364              
  Lines       20692    20692              
==========================================
- Hits        19877    19874       -3     
- Misses        622      624       +2     
- Partials      193      194       +1
Flag Coverage Δ
badger_v1 9.76% <ø> (ø)
badger_v2 1.82% <ø> (ø)
cassandra-4.x-v1-manual 14.81% <ø> (ø)
cassandra-4.x-v2-auto 1.81% <ø> (ø)
cassandra-4.x-v2-manual 1.81% <ø> (ø)
cassandra-5.x-v1-manual 14.81% <ø> (ø)
cassandra-5.x-v2-auto 1.81% <ø> (ø)
cassandra-5.x-v2-manual 1.84% <ø> (+0.03%) ⬆️
elasticsearch-6.x-v1 19.15% <ø> (ø)
elasticsearch-7.x-v1 19.23% <ø> (ø)
elasticsearch-8.x-v1 19.40% <ø> (ø)
elasticsearch-8.x-v2 1.82% <ø> (ø)
grpc_v1 10.81% <ø> (ø)
grpc_v2 7.80% <ø> (ø)
kafka-3.x-v1 10.13% <ø> (ø)
kafka-3.x-v2 1.82% <ø> (ø)
memory_v2 1.82% <ø> (ø)
opensearch-1.x-v1 19.28% <ø> (ø)
opensearch-2.x-v1 19.28% <ø> (ø)
opensearch-2.x-v2 1.82% <ø> (ø)
tailsampling-processor 0.48% <ø> (ø)
unittests 94.93% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ary82
init submodule in CI
bd060da 
Signed-off-by: Aryan Goyal <137564277+ary82@users.noreply.github.com>
yurishkuro
yurishkuro reviewed Feb 19, 2025
View reviewed changes
.github/workflows/ci-lint-checks.yaml Outdated
submodules: recursive

- name: Initialize and update submodule
run: git submodule update --init --recursive
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't submodules option above achieves the same?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, CI is giving an error message from git

fatal: No names found, cannot describe anything.

But it should be something like:

fatal: no tag exactly matches 'bdfc239c55cdff96bd3b1caaf6849ada43d7402e'

which suggests there might be something wrong with fetching the submodules. I was trying to troubleshoot it with this command

ary82 added 2 commits February 19, 2025 09:49
@ary82
fix
b887740 
Signed-off-by: Aryan Goyal <137564277+ary82@users.noreply.github.com>
@ary82
fix
3c154ca 
Signed-off-by: Aryan Goyal <137564277+ary82@users.noreply.github.com>
yurishkuro
yurishkuro reviewed Feb 19, 2025
View reviewed changes
@ary82 @yurishkuro
Update scripts/lint/check-jaeger-idl-version.sh
cb9b4fe 
Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
Signed-off-by: Aryan Goyal <137564277+ary82@users.noreply.github.com>
@yurishkuro
Copy link
Member

why do the logs show downloading go1.24?

Run make lint-jaeger-idl-versions
go: downloading go1.2[4](https://github.com/jaegertracing/jaeger/actions/runs/13416432155/job/37478289270#step:5:5).0 (linux/amd64)
checking jaeger-idl version mismatch between git submodule and go.mod dependency
fatal: No names found, cannot describe anything.
Error: failed getting version from submodule
make: *** [Makefile:19[6](https://github.com/jaegertracing/jaeger/actions/runs/13416432155/job/37478289270#step:5:7): lint-jaeger-idl-versions] Error 1

yurishkuro
yurishkuro approved these changes Feb 19, 2025
View reviewed changes
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now that we've seen the test fail, please update the idl submodule to make sure that the CI is green in this PR.

@yurishkuro
Bump idl submodule to v0.5.0
4a34a43 
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro enabled auto-merge February 19, 2025 18:21
@yurishkuro
Copy link
Member

@ary82 why is it still failing now that the versions are the same?

@yurishkuro yurishkuro added this pull request to the merge queue Feb 19, 2025
Merged via the queue into jaegertracing:main with commit ab25385 Feb 19, 2025
55 of 56 checks passed
@ary82
Copy link
Contributor Author

ary82 commented Feb 19, 2025

@ary82 why is it still failing now that the versions are the same?

Still working on it but the error suggests something might be wrong with fetching the submodules. I was testing it with act but that seems to run fine.
Should I revert this?

@ary82
Copy link
Contributor Author

ary82 commented Feb 19, 2025 •
edited
Loading

why do the logs show downloading go1.24?

Run make lint-jaeger-idl-versions
go: downloading go1.2[4](https://github.com/jaegertracing/jaeger/actions/runs/13416432155/job/37478289270#step:5:5).0 (linux/amd64)
checking jaeger-idl version mismatch between git submodule and go.mod dependency
fatal: No names found, cannot describe anything.
Error: failed getting version from submodule
make: *** [Makefile:19[6](https://github.com/jaegertracing/jaeger/actions/runs/13416432155/job/37478289270#step:5:7): lint-jaeger-idl-versions] Error 1

@yurishkuro something in the Makefile is implicitly triggering the go setup, as we're using make lint-jaeger-idl-versions for this job

@yurishkuro yurishkuro mentioned this pull request Feb 19, 2025
Merged
@yurishkuro yurishkuro added changelog:ci Change related to continuous integration / testing and removed changelog:bugfix-or-minor-feature labels Feb 19, 2025
yurishkuro added a commit that referenced this pull request Feb 19, 2025
@yurishkuro
[idl check] Fetch tags (#6758)
46a7096 
## Which problem is this PR solving?
- The test in #6753 was still failing, even with the submodule update

## Description of the changes
- Try to fetch tags

## How was this change tested?
- CI

---------

Signed-off-by: Yuri Shkuro <github@ysh.us>
@ary82 ary82 deleted the lint-idl-version branch February 19, 2025 20:23
amilbcahat pushed a commit to amilbcahat/jaeger that referenced this pull request May 4, 2025
@yurishkuro @amol-verma-allen
[idl check] Fetch tags (jaegertracing#6758)
9c3ec31 
## Which problem is this PR solving?
- The test in jaegertracing#6753 was still failing, even with the submodule update

## Description of the changes
- Try to fetch tags

## How was this change tested?
- CI

---------

Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: amol-verma-allen <amol.verma@allen.in>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurishkuro yurishkuro yurishkuro approved these changes

@joe-elliott joe-elliott Awaiting requested review from joe-elliott joe-elliott is a code owner automatically assigned from jaegertracing/jaeger-maintainers

Assignees
No one assigned
Labels
changelog:ci Change related to continuous integration / testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a linter that will ensure same version of jaeger-idl dependency
2 participants
@ary82 @yurishkuro